From: Martin DeMello <martindemello@...>
Date: 2013-03-14T11:19:42+09:00
Subject: Re: RubyExcel class. Useful?

Took a quick look at the code; this bit looks wrong:

def delete(ref)
...
@sheets.delete_at( ref + 1 )

I think it should be (ref - 1). Which brings me to my main point, that
1-indexing is tricky and should be bolstered by a lot of tests in case
you inadvertently slip up. Also @sheets.delete_at changes the array
whereas @sheets.reject does not; it should be reject! for consistency.
(Again, tests would have caught this.)

martin

On Wed, Mar 13, 2013 at 8:45 AM, Joel Pearson <lists@ruby-forum.com> wrote:
> Aha! I have learned how to use Github.
>
> My hideous-looking, still under-construction code is here:
> https://github.com/VirtuosoJoel/RubyExcel
>
> I've split it into something more resembling an Excel workbook, and
> tried to reduce the redundancy of address-based code by adding a module
> called Address.
>
> I'll keep hammering bits onto it, cutting away the dross, and testing it
> until it turns into a reasonably serviceable tool.
>
> As always, any advice is welcome!
>
> --
> Posted via http://www.ruby-forum.com/.
>