From: Ricky Ng <dummey@...>
Date: 2012-12-27T06:14:43+09:00
Subject: Re: When to use Hashed Parameters for method calls.

--e89a8fb1ffc438497f04d1c7eb9e
Content-Type: text/plain; charset=ISO-8859-1

I should probably also note that I am working on a chunk of legacy code so
a lot of things are pretty stinky right now.

I know that I should refactor it, but being that this method has been
around for 6 years now, I am extremely afraid of changing the interface.

So I guess the more precise question is, during refactoring, how bad does
it have to smell to warrant potentially causing code paths to fail,
especially if there will be failures that won't be caught until down the
road.

On Wed, Dec 26, 2012 at 1:07 PM, Ryan Davis <ryand-ruby@zenspider.com>wrote:

> estion the type of arguments... Question the number of arguments. 8 just
> reeks of design smell.




-- 
Incoherently,
Ricky Ng

--e89a8fb1ffc438497f04d1c7eb9e
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra">I should probably also note tha=
t I am working on a chunk of legacy code so a lot of things are pretty stin=
ky right now.=A0</div><div class=3D"gmail_extra"><br></div><div class=3D"gm=
ail_extra">
I know that I should refactor it, but being that this method has been aroun=
d for 6 years now, I am extremely afraid of changing the interface.=A0</div=
><div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra">So I guess=
 the more precise question is, during refactoring, how bad does it have to =
smell to=A0warrant=A0potentially causing code paths to fail, especially if =
there will be failures that won&#39;t be caught until down the road.=A0<br>
<br><div class=3D"gmail_quote">On Wed, Dec 26, 2012 at 1:07 PM, Ryan Davis =
<span dir=3D"ltr">&lt;<a href=3D"mailto:ryand-ruby@zenspider.com" target=3D=
"_blank">ryand-ruby@zenspider.com</a>&gt;</span> wrote:<br><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex">
estion the type of arguments... Question the number of arguments. 8 just re=
eks of design smell.</blockquote></div><br><br clear=3D"all"><div><br></div=
>-- <br>Incoherently,<br>Ricky Ng
</div></div>

--e89a8fb1ffc438497f04d1c7eb9e--