From: Josh Cheek <josh.cheek@...>
Date: 2012-09-07T15:44:04+09:00
Subject: Re: best coding for limiting a value

--047d7b5d33e4fd70c604c916eecf
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Sep 4, 2012 at 3:13 PM, Regis d'Aubarede <lists@ruby-forum.com>wrote:

> A)  result=value<min ? min : (value > max ? max : value)
>
> B)
> result=value
> if value < min then result= min  end
> if value > max then result= max  end
>
> C)
> [min,max,value].sort[1]
>
>
I like (B) best. Initially I liked (C), b/c it's easiest to parse. But I
read it as 'select the middle value' Then I figured I should actually read
the others, and realized it was "select the closest value in range". But +1
to what Peter Hickman said about picking a good name will make it largely
irrelevant which one you choose (i.e. don't just drop this into the middle
of some code, wrap it in a descriptive method name).

def closest_in_bounds(value)
  return min if value < min_value
  return max if max_value < value
  value
end

This does make the assumption that your min and max are methods, which
assumes you're already following an OO style of writing, but based on your
initial examples, it's difficult to tell if this is the case.

--047d7b5d33e4fd70c604c916eecf
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 4, 2012 at 3:13 PM, Regis d&#39;Aubarede <span dir=3D"ltr">&lt;=
<a href=3D"mailto:lists@ruby-forum.com" target=3D"_blank">lists@ruby-forum.=
com</a>&gt;</span> wrote:<br><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
A) =A0result=3Dvalue&lt;min ? min : (value &gt; max ? max : value)<br>
<br>
B)<br>
result=3Dvalue<br>
if value &lt; min then result=3D min =A0end<br>
if value &gt; max then result=3D max =A0end<br>
<br>
C)<br>
[min,max,value].sort[1]<br>
<br></blockquote><br>I like (B) best. Initially I liked (C), b/c it&#39;s e=
asiest to parse. But I read it as &#39;select the middle value&#39; Then I =
figured I should actually read the others, and realized it was &quot;select=
 the closest value in range&quot;. But +1 to what Peter Hickman said about =
picking a good name will make it largely irrelevant which one you choose (i=
.e. don&#39;t just drop this into the middle of some code, wrap it in a des=
criptive method name).<br>
<br>def closest_in_bounds(value)<br>=A0 return min if value &lt; min_value<=
br>=A0 return max if max_value &lt; value<br>=A0 value<br>end<br><br>This d=
oes make the assumption that your min and max are methods, which assumes yo=
u&#39;re already following an OO style of writing, but based on your initia=
l examples, it&#39;s difficult to tell if this is the case.<br>
</div>

--047d7b5d33e4fd70c604c916eecf--