From: Luis Lavena Date: 2012-07-24T09:34:37+09:00 Subject: Re: [ruby-cvs:43685] luislavena:r36509 (trunk): Fix raw UTF-8 test for non-Japanase Windows systems On Mon, Jul 23, 2012 at 9:30 PM, Eric Hodel wrote: > > On Jul 23, 2012, at 16:32, luislavena@ruby-lang.org wrote: > >> luislavena 2012-07-24 08:32:29 +0900 (Tue, 24 Jul 2012) >> >> New Revision: 36509 >> >> http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=36509 >> >> Log: >> Fix raw UTF-8 test for non-Japanase Windows systems >> >> * test/ruby/test_dir_m17n.rb (create_and_check_raw_file_name): add new >> helper method to ease encoding testing. Patch by Oleg Sukhodolsky. >> [ruby-core:46589][Bug #6765] >> >> * test/ruby/test_dir_m17n.rb (test_filename_extutf8): use filesystem >> encoding when reading entries and comparing. >> >> * test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_name): removed. >> >> * test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_jp_name): split test. >> >> Modified files: >> trunk/ChangeLog >> trunk/test/ruby/test_dir_m17n.rb > > This change causes a failure on OS X 10.7.4: > > [12/13] TestDir_M17N#test_filename_utf8_raw_windows_1252_name = 0.02 s > 1) Failure: > test_filename_utf8_raw_windows_1252_name(TestDir_M17N) [/Users/drbrain/Work/svn/ruby/trunk/test/ruby/test_dir_m17n.rb:23]: > character 199 in UTF-8 (#) > Hmn, this test passed on my Snow Leopard box and also Ubuntu 12.04 > When I run the script by hand I get a filename of "Ç" (That's U+0043 latin capital letter C, U+0327 combining cedilla). I'm unsure what the expected result is. > I think Windows-1252 and Windows-1251 tests can be skipped on non-Windows platforms, but is weird because it worked on this side of the world. > PS: I changed the assertions slightly to be more informative about failures: > Can you tell me what the assertions say on your side? -- Luis Lavena AREA 17 - Perfection in design is achieved not when there is nothing more to add, but rather when there is nothing more to take away. Antoine de Saint-Exupéry