From: "Jan E." <lists@...>
Date: 2012-06-28T00:05:47+09:00
Subject: Re: Is this good code

Avdi Grimm wrote in post #1066354:
>     def some_other_method
>        return unless condition
>       if
>         ...some code
>       else
>         ..some code
>        end
>      end

To be honest, I find this almost as obscure as the original code. A 
method doing nothing if a certain condition isn't met? I think the 
*method call* should be conditional rather than the method body. In 
other words: I'd move the "unless" outside of the method body.

But I'm not even sure if we actually have an "if" inside an "unless", 
because mastablasta's indentation suggest the "unless" belongs to 
another statement or maybe a block (which we cannot see).

-- 
Posted via http://www.ruby-forum.com/.