From: Avdi Grimm <groups@...>
Date: 2012-06-20T09:23:40+09:00
Subject: Re: Looking for a better way to add a method to a core class than monkey patching

--0016e6dd8983e2472004c2dc6882
Content-Type: text/plain; charset=ISO-8859-1

Please do not monkey patch core libraries in gems, unless the *purpose* of
your library is to add functionality to core, eg a library of extensions
like activesupport. Yes, this goes for additions as well as overrides. I
cannot tell you how many times I've seen a "harmless addition" mess things
up in confusing and hard to debug ways.

What method do you want to add to strings?

--
Avdi Grimm
http://avdi.org
On Jun 19, 2012 1:35 PM, "Iain Barnett" <iainspeed@gmail.com> wrote:

> Hi all,
>
> I'd like to add a method to the String class for a gem I'm making.
> Obviously, I could just open it up and pop the method in, but I'd like to
> know what is the state-of-the-art for adding a method. Do I get anything
> better from putting the method in a module and then opening up the class
> and including it? I can't see why but I'd like to know.
>
> I don't wish to use a new class that inherits from String because I
> understand that there's a gotcha with String due to something done for
> performance reasons (though I can't remember the exact details I remember
> the warning!), and there's obvious good sides to the method being directly
> in String that far outweigh the inheritance angle.
>
> Any thoughts or suggestions would be appreciated.
>
> Regards,
> Iain
>

--0016e6dd8983e2472004c2dc6882
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<p>Please do not monkey patch core libraries in gems, unless the *purpose* =
of your library is to add functionality to core, eg a library of extensions=
 like activesupport. Yes, this goes for additions as well as overrides. I c=
annot tell you how many times I&#39;ve seen a &quot;harmless addition&quot;=
 mess things up in confusing and hard to debug ways. </p>

<p>What method do you want to add to strings? </p>
<p>--<br>
Avdi Grimm<br>
<a href=3D"http://avdi.org">http://avdi.org</a> </p>
<div class=3D"gmail_quote">On Jun 19, 2012 1:35 PM, &quot;Iain Barnett&quot=
; &lt;<a href=3D"mailto:iainspeed@gmail.com">iainspeed@gmail.com</a>&gt; wr=
ote:<br type=3D"attribution"><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi all,<br>
<br>
I&#39;d like to add a method to the String class for a gem I&#39;m making. =
Obviously, I could just open it up and pop the method in, but I&#39;d like =
to know what is the state-of-the-art for adding a method. Do I get anything=
 better from putting the method in a module and then opening up the class a=
nd including it? I can&#39;t see why but I&#39;d like to know.<br>

<br>
I don&#39;t wish to use a new class that inherits from String because I und=
erstand that there&#39;s a gotcha with String due to something done for per=
formance reasons (though I can&#39;t remember the exact details I remember =
the warning!), and there&#39;s obvious good sides to the method being direc=
tly in String that far outweigh the inheritance angle.<br>

<br>
Any thoughts or suggestions would be appreciated.<br>
<br>
Regards,<br>
Iain<br>
</blockquote></div>

--0016e6dd8983e2472004c2dc6882--