From: Samuel Williams <space.ship.traveller@...>
Date: 2012-06-12T01:28:55+09:00
Subject: Is resolv.rb broken in 1.9.3 due to encodings?

--90e6ba5bbba17e015304c234d831
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I'm trying to work through some issues using 1.9.3 for my project RubyDNS,
and I noticed the following code in resolv.rb's MessageEncoder:

      class MessageEncoder # :nodoc:
        def initialize
          @data = ''
          @names = {}
          yield self
        end

        def to_s
          return @data
        end

        def put_bytes(d)
          @data << d
        end

        def put_pack(template, *d)
          @data << d.pack(template)
        end

        def put_length16
          length_index = *@data.length*
          @data << "\0\0"
          data_start = *@data.length*
          yield
          data_end = *@data.length*
*          @data[length_index, 2] = [data_end - data_start].pack("n")*
        end

I'm just wondering, shouldn't this be using byteslice, bytesize and
friends? Isn't this code completely broken by default since we use UTF-8
encoding? Am I missing something?

Kind regards,
Samuel

--90e6ba5bbba17e015304c234d831
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,<div><br></div><div>I&#39;m trying to work through some issues using 1.9=
.3 for my project RubyDNS, and I noticed the following code in resolv.rb&#3=
9;s MessageEncoder:</div><div><br></div><div><div>=A0 =A0 =A0 class Message=
Encoder # :nodoc:</div>
<div>=A0 =A0 =A0 =A0 def initialize</div><div>=A0 =A0 =A0 =A0 =A0 @data =3D=
 &#39;&#39;</div><div>=A0 =A0 =A0 =A0 =A0 @names =3D {}</div><div>=A0 =A0 =
=A0 =A0 =A0 yield self</div><div>=A0 =A0 =A0 =A0 end</div><div><br></div><d=
iv>=A0 =A0 =A0 =A0 def to_s</div><div>=A0 =A0 =A0 =A0 =A0 return @data</div=
>
<div>=A0 =A0 =A0 =A0 end</div><div><br></div><div>=A0 =A0 =A0 =A0 def put_b=
ytes(d)</div><div>=A0 =A0 =A0 =A0 =A0 @data &lt;&lt; d</div><div>=A0 =A0 =
=A0 =A0 end</div><div><br></div><div>=A0 =A0 =A0 =A0 def put_pack(template,=
 *d)</div><div>=A0 =A0 =A0 =A0 =A0 @data &lt;&lt; d.pack(template)</div>
<div>=A0 =A0 =A0 =A0 end</div><div><br></div><div>=A0 =A0 =A0 =A0 def put_l=
ength16</div><div>=A0 =A0 =A0 =A0 =A0 length_index =3D <b>@data.length</b><=
/div><div>=A0 =A0 =A0 =A0 =A0 @data &lt;&lt; &quot;\0\0&quot;</div><div>=A0=
 =A0 =A0 =A0 =A0 data_start =3D <b>@data.length</b></div>
<div>=A0 =A0 =A0 =A0 =A0 yield</div><div>=A0 =A0 =A0 =A0 =A0 data_end =3D <=
b>@data.length</b></div><div><b>=A0 =A0 =A0 =A0 =A0 @data[length_index, 2] =
=3D [data_end - data_start].pack(&quot;n&quot;)</b></div><div>=A0 =A0 =A0 =
=A0 end</div></div><div><br></div><div>
I&#39;m just wondering, shouldn&#39;t this be using byteslice, bytesize and=
 friends? Isn&#39;t this code completely broken by default since we use UTF=
-8 encoding? Am I missing something?</div><div><br></div><div>Kind regards,=
</div>
<div>Samuel</div>

--90e6ba5bbba17e015304c234d831--