From: Michal Rokos <m.rokos@...>
Date: 2002-05-02T00:09:55+09:00
Subject: Re: [RFC] Ranges - enable (10..-10)

Hi,

In article <aaofci$2m0i$1@ns.felk.cvut.cz>, Michal Rokos wrote:
> 	Is it a mistake or you changed your mind?

	In case it was a mistake, here is the patch that drops
	functionality again...

	(Posting now, I'm going off for the weekend...)

		Michal


Index: range.c
===================================================================
RCS file: /src/ruby/range.c,v
retrieving revision 1.33
diff -u -r1.33 range.c
--- range.c	2002/05/01 09:41:49	1.33
+++ range.c	2002/05/01 14:46:51
@@ -78,7 +78,7 @@
 	rb_name_error(rb_intern("initialize"), "`initialize' called twice");
     }
     range_init(obj, beg, end, RTEST(flags));
-    return Qnil;
+    return obj;
 }
 
 static VALUE
@@ -265,26 +265,17 @@
     }
 
     if (FIXNUM_P(b) && FIXNUM_P(e)) { /* fixnums are special */
-	long beg = FIX2LONG(b), end = FIX2LONG(e), s = NUM2LONG(step);
+	long beg, end = FIX2LONG(e), s = NUM2LONG(step);
 	long i;
 	if (s <= 0) {
 	    rb_raise(rb_eArgError, "step can't be <= 0");
 	}
-	if ((end - beg) < 0) {
-	    if (!EXCL(range)) end -= 1;
-	    for (i=beg; i>end; i-=s) {
-		rb_yield(LONG2NUM(i));
-	    }
+	if (!EXCL(range)) end += 1;
+	for (i=FIX2LONG(b); i<end; i+=s) {
+	    rb_yield(INT2NUM(i));
 	}
-	else {
-	    if (!EXCL(range)) end += 1;
-	    for (i=beg; i<end; i+=s) {
-		rb_yield(INT2NUM(i));
-	    }
-	}
     }
     else if (rb_obj_is_kind_of(b, rb_cNumeric)) {
-	VALUE diff;
 	b = rb_Integer(b);
 	e = rb_Integer(e);
 	step = rb_Integer(step);
@@ -292,21 +283,11 @@
 	if (RTEST(rb_funcall(step, rb_intern("<="), 1, INT2FIX(0)))) {
 	    rb_raise(rb_eArgError, "step can't be <= 0");
 	}
-	diff = rb_funcall(e, '-', 1, b);
-	if (RTEST(rb_funcall(diff, '<', 1, INT2FIX(0)))) {
-	    if (!EXCL(range)) e = rb_funcall(e, '-', 1, INT2FIX(1));
-	    while (RTEST(rb_funcall(b, '>', 1, e))) {
-		rb_yield(b);
-		b = rb_funcall(b, '-', 1, step);
-	    }
+	if (!EXCL(range)) e = rb_funcall(e, '+', 1, INT2FIX(1));
+	while (RTEST(rb_funcall(b, '<', 1, e))) {
+	    rb_yield(b);
+	    b = rb_funcall(b, '+', 1, step);
 	}
-	else {
-	    if (!EXCL(range)) e = rb_funcall(e, '+', 1, INT2FIX(1));
-	    while (RTEST(rb_funcall(b, '<', 1, e))) {
-		rb_yield(b);
-		b = rb_funcall(b, '+', 1, step);
-	    }
-	}
     }
     else if (TYPE(b) == T_STRING) {
 	VALUE args[5];
@@ -314,14 +295,20 @@
 
 	args[0] = b; args[1] = e; args[2] = range;
 	iter[0] = 1; iter[1] = NUM2LONG(step);
+	if (iter[1] <= 0) {
+	    rb_raise(rb_eArgError, "step can't be <= 0");
+	}
 	rb_iterate((VALUE(*)_((VALUE)))r_step_str, (VALUE)args, r_step_str_i,
 		   (VALUE)iter);
     }
     else {			/* generic each */
 	VALUE v = b;
-	long lim = NUM2INT(step);
+	long lim = NUM2LONG(step);
 	long i;
 
+	if (lim <= 0) {
+	    rb_raise(rb_eArgError, "step can't be <= 0");
+	}
 	if (EXCL(range)) {
 	    while (r_lt(v, e)) {
 		if (r_eq(v, e)) break;

-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Michal Rokos                         Czech Technical University, Prague
E-mail:m.rokos@sh.cvut.cz  ICQ:36118339  Jabber:majkl@jabber.sh.cvut.cz
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-