From: Intransition <transfire@...>
Date: 2012-01-16T09:30:47+09:00
Subject: The Better Code

------=_Part_1587_19647082.1326673842786
Content-Type: multipart/alternative; 
	boundary="----=_Part_1588_32901699.1326673842786"

------=_Part_1588_32901699.1326673842786
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Which would you judge to be the better code?

The concise:

    def self.assert(*a, &b)
      o = Hash === a.last ? a.pop : {}

      t = o[:backtrace] || caller
      m = o[:message]

      e = new(m, *a, &b)
      e.set_backtrace(t)
      e.assert
    end

Or the more explicit:

    def self.assert(*arguments, &block)
      options = (Hash === arguments.last ? arguments.pop : {})

      backtrace = options[:backtrace] || caller
      message   = options[:message]

      assay = new(message, *arguments, &block)
      assay.set_backtrace(backtrace)
      assay.assert
    end

Which and why?

------=_Part_1588_32901699.1326673842786
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

Which would you judge to be the better code?<br><br>The concise:<br><br>&nbsp; &nbsp; def self.assert(*a, &amp;b)<br>&nbsp; &nbsp; &nbsp; o = Hash === a.last ? a.pop : {}<br><br>&nbsp;&nbsp; &nbsp;&nbsp; t = o[:backtrace] || caller<br>&nbsp;&nbsp; &nbsp;&nbsp; m = o[:message]<br><br>&nbsp; &nbsp; &nbsp; e = new(m, *a, &amp;b)<br>&nbsp;&nbsp; &nbsp;&nbsp; e.set_backtrace(t)<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; e.assert<br>&nbsp;&nbsp;&nbsp; end<br><br>Or the more explicit:<br><br>&nbsp; &nbsp; def self.assert(*arguments, &amp;block)<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; options = (Hash === arguments.last ? arguments.pop : {})<br><br>&nbsp; &nbsp; &nbsp; backtrace = options[:backtrace] || caller<br>&nbsp;&nbsp; &nbsp;&nbsp; message&nbsp;&nbsp; = options[:message]<br><br>&nbsp; &nbsp; &nbsp; assay = new(message, *arguments, &amp;block)<br>&nbsp;&nbsp; &nbsp;&nbsp; assay.set_backtrace(backtrace)<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; assay.assert<br>&nbsp;&nbsp;&nbsp; end<br><br>Which and wh
 y?<br>
------=_Part_1588_32901699.1326673842786--

------=_Part_1587_19647082.1326673842786--