Re: Class instance variable question

On Mon, Jan 9, 2012 at 7:26 PM, Matt Mencel <[e-mail]> wrote:
> Hi,
>
> I have this class (below) that takes a deeply nested hash and returns bac=
k a new hash without all the nesting. =A0The problem I'm having is that it =
seems to be that @all_values is not empty if I call it a second time from m=
y program. =A0First time is fine, but the next time I use get_all_values_ne=
sted, @all_values still has the results in it from the first time it was us=
ed.
>
> Any thoughts on what I'm doing wrong? =A0I just want @path and @all_value=
s to be empty each time I use the get_all_values_nested function.
>
> Thanks,
> Matt
>
>
>
>
> class Tools
>
> =A0@path =3D []
> =A0@all_values =3D {}
>
> =A0def self.get_all_values_nested(nested_hash=3D{})
> =A0 =A0puts "ALL VALS: #{@all_values}"
> =A0 =A0nested_hash.each_pair do |k,v|
> =A0 =A0 =A0@path << k
> =A0 =A0 =A0case v
> =A0 =A0 =A0 =A0when Array, DateTime, FalseClass, Fixnum, NilClass, String=
, TrueClass then
> =A0 =A0 =A0 =A0 =A0@all_values.merge!({"#{@path.join(".")}" =3D> "#{v}"})
> =A0 =A0 =A0 =A0 =[e-mail]
> =A0 =A0 =A0 =A0when Hash then get_all_values_nested(v)
> =A0 =A0 =A0 =A0else raise ArgumentError, "Unhandled type #{v.class}"
> =A0 =A0 =A0end
> =A0 =A0end
> =A0 =[e-mail]
>
> =A0 =A0return @all_values
> =A0end
>
> end

Instance variables keep their value after the method execution, that's
why you are seeing that problem.
Instead of using an instance variable you could just use the return
value of the recursive call to merge it to a local variable that you
then return. This way you won't need instance variables at all:

require 'date'

class Tools
  def self.get_all_values_nested(nested_hash=3D{}, path=3D[])
    all_values =3D {}
    nested_hash.each_pair do |k,v|
      path << k
      case v
        when Array, DateTime, FalseClass, Fixnum, NilClass, String,
TrueClass then
          all_values.merge!({"#{path.join(".")}" =3D> "#{v}"})
        when Hash then
          all_values.merge!(get_all_values_nested(v, path))
        else
          raise ArgumentError, "Unhandled type #{v.class}"
      end
      path.pop
     end
     return all_values
  end
end

p Tools.get_all_values_nested({"a" =3D> 1, "b" =3D> {:first =3D> "1"}})
p Tools.get_all_values_nested({"a" =3D> {"first_level" =3D> 42, "nested"
=3D> {"key" =3D> "value"}}, "b" =3D> {:first =3D> "1"}})

$ ruby nested_hash.rb
{"a"=3D>"1", "b.first"=3D>"1"}
{"a.first_level"=3D>"42", "a.nested.key"=3D>"value", "b.first"=3D>"1"}

Does this help?

Jesus.