From: "Jesús Gabriel y Galán" Date: 2010-09-06T16:04:52+09:00 Subject: Re: My First Application On Mon, Sep 6, 2010 at 6:01 AM, Jason Hhh wrote: > I have worked with PHP in the past and have been playing with Ruby for a > few weeks.  I made a program that I would love to get feedback on.  Any > comments would be great.  I have my program on Git hub. > > http://github.com/jasonhamilton/NZBMatrix-Downloader Quick feedback: - Variables that start with $ are global variables. Try to avoid them, and specially in a program like this I think they are not needed. Make them local variables, and replace the few that you use inside the class with an instance variable that you set when creating the instance. - For an infinite loop: loop do {}, instead of while 1==1 - I can't see how you exit the loop - In the loop body, there's too much detailed processing of the message, calling to_s, downcase and indexing several times. There's probably a way to DRY that up, but I'm in a rush right now. If I have more time later I will comment a bit more. Hope this helps, Jesus.