From: Cali Wildman <caliwildman2004-info@...>
Date: 2009-05-21T13:30:27+09:00
Subject: Re: gsub choking on fixnum

Yukihiro Matsumoto wrote:
>               matz.
> diff --git a/ChangeLog b/ChangeLog
> index b5bd805..1edb627 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +Thu May 21 08:50:58 2009  Yukihiro Matsumoto  <matz@ruby-lang.org>
> +
> +  * lib/rexml/text.rb (REXML::Text.normalize): call to_s for input.
> +    [ruby-talk:337069]
> +
>  Mon May 18 21:40:11 2009  Tanaka Akira  <akr@fsij.org>
> 
>    * lib/pathname.rb (Pathname#sub): suppress a warning.
> diff --git a/lib/rexml/text.rb b/lib/rexml/text.rb
> index 2bc0042..a4a30b6 100644
> --- a/lib/rexml/text.rb
> +++ b/lib/rexml/text.rb
> @@ -286,7 +286,7 @@ module REXML
>      EREFERENCE = /&(?!#{Entity::NAME};)/
>      # Escapes all possible entities
>      def Text::normalize( input, doctype=nil, entity_filter=nil )
> -      copy = input
> +      copy = input.to_s
>        # Doing it like this rather than in a loop improves the speed
>        #copy = copy.gsub( EREFERENCE, '&amp;' )
>        copy = copy.gsub( "&", "&amp;" )

This is a change in the REXML code, if I have to make a change, I'm more 
comfortable with changing my own code. Is this change a REXML bug fix or 
simply a fix for my problem? I'm still trying to figure out if 1.8.6 
introduced a bug of some kind whether it be in gsub or REXML.
-- 
Posted via http://www.ruby-forum.com/.