From: matt@... (matt neuburg)
Date: 2009-05-05T10:55:15+09:00
Subject: Re: my logroll code, please critique

Derek Smith <derekbellnersmith@yahoo.com> wrote:

>         if File.exists?("development.log.10.gz")
>             File.copy("development.log.10.gz", "development.log.11.gz")
>         end
>         if File.exists?("development.log.8.gz")
>             File.copy("development.log.8.gz", "development.log.9.gz")
>         end
>         # etc, over and over and over and over

You forgot log.9, and the very fact that this can happen, along with the
patterned repetition here, would appear to be a Bad Smell (as in
"Refactoring"). Why 30 hard-coded lines when a 5-line loop will do? m.

-- 
matt neuburg, phd = matt@tidbits.com, http://www.tidbits.com/matt/
Leopard - http://www.takecontrolbooks.com/leopard-customizing.html
AppleScript - http://www.amazon.com/gp/product/0596102119
Read TidBITS! It's free and smart. http://www.tidbits.com