From: Robert Klemme Date: 2009-03-23T15:47:12+09:00 Subject: Re: Reg IO class On 23.03.2009 06:58, Abirami Selvam wrote: > Hi, > Should we close the file after reading it? Yes, of course. > Please see the code below... > > > data = IO.readlines("test.txt","r") > diskfile = File.open("test.xml","w+") > data.each do |line| > line.chomp! > diskfile.puts(line) if line.length>0 > end > > It is working fine, even without closing the file(diskfile.close). Can > someone suggest me. Does the file close automatically or not? In the first line yes, in the second chunk, no. This can be easily fixed by using the block form of File.open. Cheers robert -- remember.guy do |as, often| as.you_can - without end