From: Sean Hussey <seanhussey@...>
Date: 2007-10-31T03:09:23+09:00
Subject: Re: REXML (1.8.6-p110) backwards compatibility problem with rcov

Nice catch!

After applying both fixes, I now get this:

/usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:131:in `[]': no
implicit conversion from nil to integer (TypeError)
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:131:in `wrap'
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:131:in `wrap'
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:90:in
`write_text'
        from /usr/local/lib/ruby/1.8/rexml/formatters/default.rb:50:in `write'
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:75:in
`write_element'
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:73:in `each'
        from /usr/local/lib/ruby/1.8/rexml/formatters/pretty.rb:73:in
`write_element'
        from /usr/local/lib/ruby/1.8/rexml/formatters/default.rb:31:in `write'
         ... 16 levels...

rcov outputs the index.html file and the first few controller files,
so I can trace it to which file it's getting choked on, but were there
any other fixes you had to put in?

Thanks,

Sean

On 10/22/07, Brian Candler <B.Candler@pobox.com> wrote:
> On Mon, Oct 22, 2007 at 08:50:24AM +0100, Brian Candler wrote:
> > The second is almost certainly a bug in REXML: it's a misnamed local
> > variable.
>
> Oh, I see there's a fix for this in trunk already, committed 9 days ago:
> http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/lib/rexml/document.rb?r1=13597&r2=13686
> (but I don't think it has been merged to branches/ruby_1_8_6)
>
> I can't see a fix for Fixnum attribute values though.
>
> Regards,
>
> Brian.
>
>