From: Felix Windt Date: 2007-08-30T06:19:35+09:00 Subject: Re: Bug in URI.parse? ------=_NextPart_000_0000_01C7EA47.0FBED250 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit > -----Original Message----- > From: Andrew Beers [mailto:beers@tableausoftware.com] > Sent: Wednesday, August 29, 2007 1:49 PM > To: ruby-talk ML > Subject: Re: Bug in URI.parse? > > Ok lots of good responses, thanks! A few comments: > > Felix: while URI.parse() is behaving according to the two > cited RFCs, I > think it is missing an important use case. In "http://3beers-wrk", > "3beers-wrk" isn't a domain name, is it? It is an > unqualified host name That's fair - it does mention that single unqualified hostnames should work. I don't have enough time right now at work to look at the RFC for those - I'm not even sure there is one for them - and what that defines as naming standards, that might be worth investigating. > (I assume we'd pick the host name up from context. Now, the RFC also > suggests that host name must follow these rules (starting > with a letter, > etc.), and furthermore, all components of a domain name just > follow this > convention, which suggests that the regexp is common.rb is also > incorrect. :) I think it does act correctly for qualified domain names, which is important. > > Also, the solution of "rename the host" is a non-solution when dealing > with customers, who are using an otherwise perfectly > acceptable hostname > (I haven't found a tool yet that will balk at a hostname > beginning with > a number) That's true :o) > > Now, I'm not sure if the RFCs have been replaced by newer versions - > that would take some digging. I'm relatively certain it has not. > > So, John, I'd say that this is a bug in URI.parse, since it follows > neither the published RFCs nor the practical implementation of them > today (as Coey points out). And if it follows neither, it's > really not > a very good general purpose function in the Ruby library and so should > be fixed. > > Andrew Together with: > -----Original Message----- > From: RubyTalk@gmail.com [mailto:rubytalk@gmail.com] > Sent: Wednesday, August 29, 2007 1:17 PM > To: ruby-talk ML > Subject: Re: Bug in URI.parse? > > If it is a bug change toplabel in common.rb to this > > TOPLABEL = "(?:[#{ALNUM}](?:[-#{ALNUM}]*[#{ALNUM}])?)" > > Thanks to my friendly MySQL admin . > > Stephen Becker IV If it is a bug - maybe you should file on the core mailing list and enquire? -, here's a better fix: $ ruby -v ruby 1.8.5 (2006-08-25) [i486-linux] diff for uri/common.rb: 56c56 < HOSTNAME = "(?:(?:#{DOMLABEL}\\.)+#{TOPLABEL}\\.?)|(?:#{DOMLABEL}?)" --- > HOSTNAME = "(?:#{DOMLABEL}\\.)*#{TOPLABEL}\\.?" If it's a qualified domain name, enforce things as they were. If there are no sub-domains or domains to a top level domain, accept sub-domain naming stands (can start with a number) as a single, unqualified hostname. With that change: irb(main):001:0> require 'uri' => true irb(main):002:0> URI.parse('http://www.example.com') => # irb(main):003:0> URI.parse('http://2.example.com') => # irb(main):004:0> URI.parse('http://2test') => # irb(main):005:0> URI.parse('http://2test.4bad') URI::InvalidURIError: the scheme http does not accept registry part: 2test.4bad (or bad hostname?) from /usr/lib/ruby/1.8/uri/generic.rb:194:in `initialize' from /usr/lib/ruby/1.8/uri/http.rb:46:in `initialize' from /usr/lib/ruby/1.8/uri/common.rb:484:in `new' from /usr/lib/ruby/1.8/uri/common.rb:484:in `parse' from (irb):5 from :0 irb(main):006:0> Which should make everyone happy. Unfortunately, you will have to edit your uri/common.rb file for that directly - since these are declared as constants, you _can_ override them by reclaring all modules involved (you'll have to redeclare several patterns and regular expressions), but you will trigger warnings that way. Hope that helps, Felix ------=_NextPart_000_0000_01C7EA47.0FBED250 Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIII3jCCAmYw ggHPoAMCAQICEFJ3uelO4AJUNG7Np2ieTWkwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MDMxMTEzMzk1OVoXDTA4MDMxMDEzMzk1 OVowSjEfMB0GA1UEAxMWVGhhd3RlIEZyZWVtYWlsIE1lbWJlcjEnMCUGCSqGSIb3DQEJARYYZndt YWlsaW5nbGlzdHNAZ21haWwuY29tMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDoHQNMSMIi 1fb3BhJdz7Byt8PSeaa/Yx0wJ1BzLj7dJZK+8djBP06HvolZ9IYibnGerNg+LnxXT8tyGUZ0vw0Q f3qSYtuGcYfdm44qVOAtV+fex14uBSmSj8i/QOL+710oSQdPGAJE1L+8N1bLvJAxznsF6tpD5GUZ iPRY1HcloQIDAQABozUwMzAjBgNVHREEHDAagRhmd21haWxpbmdsaXN0c0BnbWFpbC5jb20wDAYD VR0TAQH/BAIwADANBgkqhkiG9w0BAQUFAAOBgQCtXsHSAFBpcohm7/t5Vlak0eySI5c5cghVELhu LyoNMdx+qCyKE4HJoWrr2+id/+YVPfiOaBsxsir3Aeg3DPuCODoafFYErm3OzJV13lRlwKWfrz01 vczScC2VvABk0ZvlQEHA54IJqiV8QoXntlQWaa2NYO3ggalUyaOeNmsk1TCCAy0wggKWoAMCAQIC AQAwDQYJKoZIhvcNAQEEBQAwgdExCzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUx EjAQBgNVBAcTCUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNVBAsT H0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMTG1RoYXd0ZSBQZXJzb25h bCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYccGVyc29uYWwtZnJlZW1haWxAdGhhd3RlLmNv bTAeFw05NjAxMDEwMDAwMDBaFw0yMDEyMzEyMzU5NTlaMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UE CBMMV2VzdGVybiBDYXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25z dWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQD ExtUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZy ZWVtYWlsQHRoYXd0ZS5jb20wgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANRp19SwlGRbcelH 2AxRtupykbCEXn0tDY97Et+FJXUodDpCLGMnn5V7S+9+GYcdhuqj3bnOlmQawhRuRKx85o/oTQ9x H0A4pgCjh3j2+ZSGXq3qwF5269kUo11uenwMpUtVfwYZKX+emibVars4JAhqmMex2qOYkf152+Va xBy5AgMBAAGjEzARMA8GA1UdEwEB/wQFMAMBAf8wDQYJKoZIhvcNAQEEBQADgYEAx+ySfk749Zal Z2IqpPBNEWDQb41gWGGsJrtSNVwIzzD7qEqWih9iQiOMFw/0umScF6xHKd+dmF7SbGBxXKKs3Hnj 524ARx+1DSjoAp3kmv0T9KbZfLH43F8jJgmRgHPQFBveQ6mDJfLmnC8Vyv6mq4oHdYsM3VGEa+T4 0c53ooEwggM/MIICqKADAgECAgENMA0GCSqGSIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMG A1UECBMMV2VzdGVybiBDYXBlMRIwEAYDVQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBD b25zdWx0aW5nMSgwJgYDVQQLEx9DZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYD VQQDExtUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFs LWZyZWVtYWlsQHRoYXd0ZS5jb20wHhcNMDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQsw CQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UE AxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQAD gY0AMIGJAoGBAMSmPFVzVftOucqZWh5owHUEcJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow 1wJjWiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenpruf ZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIBADBD BgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhhd3RlUGVyc29uYWxGcmVl bWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMTEVByaXZhdGVM YWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+vrL7CF6FDlpSdf0wh uPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRix9sncVcljd2pnDmOjCBP ZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9dX2VPMYIC+DCCAvQCAQEwdjBi MQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoG A1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0ECEFJ3uelO4AJUNG7Np2ie TWkwCQYFKw4DAhoFAKCCAdgwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUx DxcNMDcwODI5MjExNTMzWjAjBgkqhkiG9w0BCQQxFgQUjKG01x+2rmfyzkKtddeqUpbpgfkwZwYJ KoZIhvcNAQkPMVowWDAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAw BwYFKw4DAgcwDQYIKoZIhvcNAwICASgwBwYFKw4DAhowCgYIKoZIhvcNAgUwgYUGCSsGAQQBgjcQ BDF4MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0 ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBSd7npTuAC VDRuzadonk1pMIGHBgsqhkiG9w0BCRACCzF4oHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRo YXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVl bWFpbCBJc3N1aW5nIENBAhBSd7npTuACVDRuzadonk1pMA0GCSqGSIb3DQEBAQUABIGA4HocnWgo 6G3AnmYSxM+RhF8x6c6YAE/eyoAjmQVpbS61S3E0QOBI/f5ZBeoftxUqZ5K2cyS4mA8XF046IOve i5Yot7PJNtxigm75D/w6Z7c0PRxtqDu2aRtyndfTzFa369tjXqeGnLXqaClyot5yYvrLQ1XRgOJt EXtAefWVewUAAAAAAAA= ------=_NextPart_000_0000_01C7EA47.0FBED250--