From: "Ball, Donald A Jr (Library)" Date: 2007-07-28T04:18:48+09:00 Subject: Re: Help needed to DRY helpers and proper MVC with Ruby > I've got working code, but I don't think that it's done > properly so any help to make this more efficient and most of > all, correct, would be so very appreciated. Your question is perhaps best asked on the rails list. There are a couple of different things you could do to make your ActiveRecord usage more efficient, but this isn't the forum for that. http://lists.rubyonrails.org/mailman/listinfo/rails As far as making this code more rubyish, most rubyists seem to prefer iterators with blocks, e.g.: user.roles.each do |role| role.rights.each do |right| ... end end to for loops. - donald