From: Robert Dober <robert.dober@...>
Date: 2007-06-16T19:10:22+09:00
Subject: Re: Grade my test?

On 6/16/07, jabowen <ja_bowen@yahoo.com> wrote:
>
> I have directory of data files along with a few other types of files.  The
> data file names start at 0000 and run to 3999.  I have a program that
> creates an array for the data files without the non data files.  This
> program works good but have I created the shortest way of doing the task?
> Thanks for grading my test.  Jeff
>
> #Puts the contents of the current directory into data_files.
> dir_file_list = Dir.entries(".")
> data_files = []
   >
> dir_file_list.each do|files|
>         if files.to_i > 0 && files.to_i < 4000
>                 data_files.push files
>         end
> end
>
> puts data_files

Does it really work? What about file "0000' ?
The problem is that "a".to_i --> 0
I would go for

   Dir["[0-9]"*4]

or
   Dir["[0-3]" + "[0-9]"*3]
if necessary.

HTH
Robert




-- 
You see things; and you say Why?
But I dream things that never were; and I say Why not?
-- George Bernard Shaw