From: Trans Date: 2007-06-15T15:21:51+09:00 Subject: Re: Reasonable practice? On Jun 15, 12:07 am, Aatch Random wrote: > If you just want to print out all of the members of an array, it looks > fine to me. Although maybe you could just substitute the 'run' for 'puts > x'. It means about 4 less lines and one or two less variables. Unless > you plan to use that 'type' variable another time. But thats just me, i > dont always like creating one-use methods, especially such small ones. My example is a drastic simplification of what I'm actually doing. My concern is just with the practice of repeatedly changing an instance var. I've just never used an instance var in this way before, and worry I might be over looking something --especially thread issues. I used to write gigantic methods. Over the years I have learned that smaller is better. I'm getting to the point now that a method with more than nine lines is rare. You might want to give it some further consideration. Thanks, T.