From: Jano Svitok <jan.svitok@...>
Date: 2007-06-12T07:54:34+09:00
Subject: Re: Code refactoring advice

On 6/11/07, Nathan Taylor-Hoover <onebitcipher@gmail.com> wrote:
> Thank you very much Rick.  That was exactly the kind of advice I was looking
> for.  I really didn't need the OO capabilities.  Was just looking for a way
> to define functions basically.  Ended up writing the code as below since I
> am expanding it until it all works fine, and then including it into a larger
> app.

You can wrap this in a class (depending on what do you need to do with
the request.
If you don't do anything more than you have written, do (change the
name of the class as appropriate)


> #!/usr/bin/ruby
>
> require 'rubygems'
> require 'xml_struct'
> require 'uuidtools'

class XmlRequest
   XMLVER = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"

   def initialize
>     @request = XmlStruct.new
>     msguuid = UUID.random_create.to_s
>     rqstuuid = UUID.random_create.to_s
>     @request.BigWrapR = {:xmlns => "BurgerSpace"}
>     @request.BigWrapR.MyVer="1.0"
...
>     @request.BigWrapR.Verg.Stuff.MoreStuff.AnTag
>     @request.BigWrapR.Verg.MsgData
> end
>
> def namespace=(namestring)
>     @request.BigWrapR = {:xmlns => "#{namestring}"}
> end

  def to_s
     XMLVER + @request.to_s
  end
end

request = XmlRequest.new
request.namespace = "newNameSpace"
puts request.to_s

Another possibility is to derive from XmlStruct (I don't know it, so
it's possible this will not
work):

class XmlRequest < XmlStruct
   XMLVER = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"

   def initialize
       super
>     msguuid = UUID.random_create.to_s
>     rqstuuid = UUID.random_create.to_s
>     self.BigWrapR = {:xmlns => "BurgerSpace"}
>     self.BigWrapR.MyVer="1.0"
...
>     self.BigWrapR.Verg.Stuff.MoreStuff.AnTag
>     self.BigWrapR.Verg.MsgData
> end
>
> def namespace=(namestring)
>     self.BigWrapR = {:xmlns => "#{namestring}"}
> end

  def to_s
     XMLVER + super
  end
end

request = XmlRequest.new
request.namespace = "newNameSpace"
puts request.to_s

The advantage of having all this wrapped in a class is two fold:
- you hide the details of the implementation - you have here two
different implementations that look the same from the outside
- you package the related code in an entity - you don't have a bunch
of functions any more

Jano