From: aidy.lewis@... Date: 2007-05-05T01:50:05+09:00 Subject: Re: ruby and true Paul Rogers wrote > as Robert has said, its generally bad to say if x==true Not sure why it would be bad practice to compare to true? However, def test_results(result, msg) if result test_status = @test.add_element 'teststatus' test_status.text = 'PASS' else fail = @test.add_element 'teststatus' fail.text = 'FAIL!' fail_msg = @test.add_element 'failmessage' fail_msg.text = msg end end Would you see this as more appropriate? cheers aidy