From: James Edward Gray II <james@...>
Date: 2007-04-23T22:27:52+09:00
Subject: Re: [QUIZ] Morse Code (#121)

On Apr 22, 2007, at 1:03 PM, James Edward Gray II wrote:

> Begin forwarded message:
>
>> From: "Jes�s Gabriel y Gal�n" <jgabrielygalan@gmail.com>
>> Date: April 21, 2007 5:01:15 PM CDT
>> To: james@grayproductions.net
>> Subject: Re: [QUIZ] Morse Code (#121)

>> Also, I'm fairly new to Ruby, only programming little things to  
>> learn,
>> but nothing serious. So  I'd appreciate any feedback you have on my
>> Ruby.

Some minor suggestions:

* Drop the parentheses on if/while statement conditions
* while !queue.empty? could be until queue.empty?
* This bit of code:

sorted_keys = letters.keys.sort_by {|x| x.length}
min_length = sorted_keys[0].length
max_length = sorted_keys[-1].length

could be:

min_length = letters.keys.min {|a,b| a.length <=> b.length }
max_length = letters.keys.max {|a,b| a.length <=> b.length }

or:

min_length, max_length = letters.keys.sort_by {|x| x.length}.values_at 
(0, -1)

Just some thoughts.

Welcome to Ruby.

James Edward Gray II