From: jheard <jheard@...>
Date: 2001-11-10T00:47:57+09:00
Subject: [ruby-talk:24770] Re: I've ported the python nntplib class to Ruby.  I will be adding comments to it soon.  Here it is for public commentary and criticism

Yukihiro Matsumoto wrote:

> Hi,
> 
> In message "[ruby-talk:24695] Re: I've ported the python nntplib class to Ruby.  I will be adding comments to it soon.  Here it is for public commentary and criticism"
>     on 01/11/09, jheard <jheard@acxiom.com> writes:
> 
> |Sounds great! Osewa ni narimasu.
> 
> OK.  Comments from me:
> 
> |require 'net/protocol'
> 
> I don't think you need to require this one.  net/protocol is a bit
> complicated beast.
> 
> |   def initialize(host, port=nil, user=nil, password=nil, readermode=nil)
> 
> How about the following?
> 
> 
>>  def initialize(host, port=NNTP_PORT, user=nil, password=nil, readermode=nil)
>>
> 
> And it might be better to make some internal methods 'private'.
> 
> 							matz.
> 
> 

Thanks, I'll start work on it.