From: pere.noel@... (=?ISO-8859-1?Q?Une_b=E9vue?=)
Date: 2006-08-31T00:30:32+09:00
Subject: Re: [MacOS X][ANN] RAliasFile Initial Release

Luc Heinrich <luc@honk-honk.com> wrote:

> Ok, here we go:
> 
> 1. The RUBY_PLATFORM test in your extconf.rb file is broken. It will
> only allow to build the extension for a ruby *built* under 10.4.7.  
> For example, it will fail for a ruby built on 10.4.6 but running  
> under 10.4.7. And the regexp you are using is incorrect to begin with
> ('.' does not match '.', but any character).

ok, i've corrected that to /powerpc-darwin8\.\d\.\d/

> 
> 2. You are adding include paths to CFLAGS which you don't need. Only
> Carbon and CoreFoundation are required, you can remove everything else.
> 
> 3. Same for LDFLAGS, you only need to link against the Carbon and  
> CoreFoundation frameworks, forget about CoreServices and Foundation.

ok corrected

> 4. I have no idea how your extension can work, because it really  
> should not. You are defining methods for RAliasFile which is a global
> variable set to Qnil, instead of defining them for cRAliasFile which
> you correctly define first. This makes no sense. Remove RAliasFile,  
> you don't need it.
> 
> 5. Same story for the alias_path global variable, it's totally  
> useless as far as I can tell.

ok too...

> 6. Having "version" as an instance method is bogus, you should  
> probably make it a singleton method.

fixed ))

thanks a lot for your help, i now have a 0.0.2 version ...
-- 
une b�vue