From: Luc Heinrich <luc@...>
Date: 2006-08-30T23:08:32+09:00
Subject: Re: [MacOS X][ANN] RAliasFile Initial Release

On 30 ao�t 06, at 13:05, Une b�vue wrote:

> I'd be glad hearing comments upon it.

Ok, here we go:

1. The RUBY_PLATFORM test in your extconf.rb file is broken. It will  
only allow to build the extension for a ruby *built* under 10.4.7.  
For example, it will fail for a ruby built on 10.4.6 but running  
under 10.4.7. And the regexp you are using is incorrect to begin with  
('.' does not match '.', but any character).

2. You are adding include paths to CFLAGS which you don't need. Only  
Carbon and CoreFoundation are required, you can remove everything else.

3. Same for LDFLAGS, you only need to link against the Carbon and  
CoreFoundation frameworks, forget about CoreServices and Foundation.

4. I have no idea how your extension can work, because it really  
should not. You are defining methods for RAliasFile which is a global  
variable set to Qnil, instead of defining them for cRAliasFile which  
you correctly define first. This makes no sense. Remove RAliasFile,  
you don't need it.

5. Same story for the alias_path global variable, it's totally  
useless as far as I can tell.

6. Having "version" as an instance method is bogus, you should  
probably make it a singleton method.


That's after a quick 5mn look, there's probably more to say... :)

-- 
Luc Heinrich - luc@honk-honk.com - http://www.honk-honk.com