From: Pit Capitain <pit@...>
Date: 2006-05-16T18:39:30+09:00
Subject: Re: Weird class-loading issue (or maybe a problem with define_method?)

Pat Maddox schrieb:
> I've got all the source code at
> http://svn.flpr.org/public/refactoringbdd  It's very small, so it
> wouldn't take more than a few minutes to look at.

Pat, I haven't looked very carefully, but noted two things:

Too many requires: for example, in customer.rb you require "rental", but 
you don't use the Rental class. Skip those require statements.

Duplicated knowledge: the connection between price codes and price 
subclasses is duplicated in Movie#price_code= and in the price 
subclasses themselves. Try to remove this duplication. I don't think it 
is a good idea that the Price class has to know something about price 
codes, which seems to be a concept of the Movie class.

Regards,
Pit