From: kiol <yanping.jia@...>
Date: 2006-02-21T09:38:34+09:00
Subject: Newbie: need suggestion for "the ruby way"

I write some code for generate file index for a directory.like this:
#!/usr/local/bin/ruby

def parse_options(args)
  require 'optparse'
  require 'ostruct'

  options = OpenStruct.new
  opts = OptionParser.new("Usage: genindex [options] paths")
  options.dirs = []
  opts.on_tail("-h", "--help", "Show this message") do
    puts opts
    exit
  end
  opts.on_tail("-v", "--version", "Show version") do
    require '../version'
    puts Version.join('.')
    exit
  end
  rest = opts.parse(args)
  if rest.empty?:
    puts opts
  else
    rest.each {|dir| options.dirs.push(Dir.new(File.expand_path(dir)))}
  end
  if $DEBUG
    puts "get params:"
    options.dirs.each {|dir| puts dir.path}
    puts "end"
  end
  options
end

def get_indexs(curdir, indexs)
  puts 'indexing ', curdir.path if $DEBUG
  curdir.each do |f|
    next if ['.svn', '.', '..'].include?(f)
    if File.directory?(File.join(curdir.path,f))
      get_indexs(Dir.new(File.join(curdir.path,f)), indexs)
    else
      #it's case insensitive
      indexs[f.downcase] ||= []
      indexs[f.downcase] += [File.join(curdir.path, f)]
    end
  end
end

def create_idx_file(options)
  data_dir = File.join(File.dirname(File.expand_path(__FILE__)), '..',
'data')
  Dir.mkdir(data_dir) if not File.exist?(data_dir)
  Dir.chdir(data_dir) do
    options.dirs.each do |dir|
      d = dir.path.split(File::SEPARATOR).join('_')
      next if Dir.foreach('.') do |idxdir|
        next if ['.', '..', '.svn'].include?(idxdir)
        #sub dir need be ingored but same dir need recreate
        if d != idxdir and d.index(idxdir) == 0
          puts "path #{File.join(d.split('_'))} is ingored."
          puts "Because it's ancestors path
#{File.join(idxdir.split('_'))} already been indexed."
          break true
        end
      end

      Dir.mkdir(d) if not File.exist?(d)
      Dir.chdir(d) do
        File.open('indexs.yaml', 'w') do |idx_file|
          require 'yaml'
          indexs = {}
          get_indexs(dir, indexs)
          YAML.dump(indexs, idx_file)
        end
      end
    end
  end
end

if $0 == __FILE__
  begin
    create_idx_file(parse_options(ARGV))
  rescue Exception => e
    puts e.to_s
  end
end
and the test code is :
#!/usr/local/bin/ruby
$:.unshift(File.join(File.dirname(__FILE__),"..", "lib"))

require 'test/unit'
require 'genindex'
require 'optparse'

class TextGenIndex < Test::Unit::TestCase
  def test_option_parse
    args = ["."]
    assert_equal(File.expand_path("."),
parse_options(args).dirs[0].path)
    args = ['..']
    assert_equal(File.expand_path(".."),
parse_options(args).dirs[0].path)
    args = ["-sdf"]
    assert_raise(OptionParser::InvalidOption) {parse_options(args)}
    args = ["/var","/tmp"]
    assert_equal("/var", parse_options(args).dirs[0].path)
    assert_equal("/tmp", parse_options(args).dirs[1].path)
  end
  def test_create_idx_file
    data_dir = File.join(File.dirname(File.expand_path(__FILE__)),
'..', 'data')
    args = ['.']
    create_idx_file(parse_options(args))
    assert_equal(File.exist?(data_dir), true)
    index_dir = File.join(File.dirname(File.expand_path(__FILE__)),
'..', 'data', File.expand_path('.').split(File::SEPARATOR).join('_'))
    assert_equal(File.exist?(index_dir), true)
    args = ['lib', 'test']
    create_idx_file(parse_options(args))
    assert_equal(File.exist?(File.join(data_dir,
data_dir.split(File::SEPARATOR)[0..-4].push('lib').join('_'))), false)
    require 'yaml'
    index_file = File.join(index_dir, 'indexs.yaml')
    indexs = YAML.load(File.open(index_file))
    assert_equal(indexs['version.rb'.downcase][0],
File.join(data_dir.split(File::SEPARATOR)[0..-4], 'version.rb'))
  end
end

I need some help for going to "the ruby way".
this my first question on the group and I must apologize for my poor
english and thanks a lot for your suggestion for my ruby code or my
english.
So, any suggestion is wellcome.