From: Daniel Berger Date: 2005-10-06T05:27:42+09:00 Subject: Re: Ruby 1.8.3 breaks Needle's logger? Jamis Buck wrote: > On Oct 5, 2005, at 9:14 AM, Berger, Daniel wrote: > >> The problem was a hard coded "Format" constant in the Logger class that >> defined the format. This was bad, but not fatal. The >> ActiveRecord/Nitro/Needle/Glue, etc, folks made it worse when, instead >> of subclassing, they redefined the Logger class and did things like >> 'remove_const "Format"', among other questionable decisions. I'm not >> sure who wrote that code first but it was, unfortunately, copied and >> used by several authors. > > > *Ahem*. For what it's worth, Needle *does* subclass Logger. ;) And > subclassing is no protection against a change in an internal API. > > - Jamis Well, this is darn strange then: djberge@~/local/src/ruby/needle-1.2.1/test-580>/opt/bin/ruby -v ALL-TESTS.rb ruby 1.8.3 (2005-05-12) [sparc-solaris2.10] Loaded suite ALL-TESTS Started ......................................................................................................................................................................... Finished in 2.039164 seconds. 169 tests, 350 assertions, 0 failures, 0 errors Yet, with 1.8.2 I see 4 test failures out of tc_logger.rb (which I just reported on the RubyForge project page). Also, why "Logger < ::Logger" ? Regards, Dan