[#50988] [Ruby master Bug#17494] ruby is hunged when using activesupport + rspec + rspec-parameterized — sue445fukuoka@...

Issue #17494 has been reported by sue445 (Go Sueyoshi).

11 messages 2020/12/31

[ruby-dev:50983] [Ruby master Feature#13368] Improve performance of Array#sum with float elements

From: hsbt@...
Date: 2020-12-26 01:27:52 UTC
List: ruby-dev #50983
Issue #13368 has been updated by hsbt (Hiroshi SHIBATA).

Assignee set to mrkn (Kenta Murata)
Status changed from Open to Closed

https://github.com/ruby/ruby/pull/1555 was merged at https://github.com/ruby/ruby/commit/2d001003e4b3a6c20ead09ed54b6726a7669f457

----------------------------------------
Feature #13368: Improve performance of Array#sum with float elements
https://bugs.ruby-lang.org/issues/13368#change-89526

* Author: watson1978 (Shizuo Fujita)
* Status: Closed
* Priority: Normal
* Assignee: mrkn (Kenta Murata)
----------------------------------------
The declaration of local variable in loop, it will initialize local variable for each run of the loop with clang generated code.
So, it shouldn't declare the local variable in heavy loop.

Array#sum with float elements will be faster around 30%.

### Before
~~~
       user     system      total        real
   3.320000   0.010000   3.330000 (  3.336088)
~~~

### After
~~~
       user     system      total        real
   2.590000   0.010000   2.600000 (  2.602399)
~~~

### Test code
~~~
require 'benchmark'

Benchmark.bmbm do |x|
  ary = []
  10000.times { ary << Random.rand }

  x.report do
    50000.times do
      ary.sum
    end
  end

end
~~~

### Patch
https://github.com/ruby/ruby/pull/1555



-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next