ruby-dev

成瀬です。

[ruby-list:44398] で DateTime に対する加算が話題になっていますが、現在の
方法は以下のような欠点があると思います。

* Rational を使う方法は直観的でない
* 24*60 等マジックナンバーを頻繁に用いる必要がある
* Time は秒、Date/DateTimeは日を基本単位としているため、
　値を流用するとはまる

> puts Time.now + 3600
2007-12-27 19:19:44 +0900 #1時間後
> puts DateTime.now + 3600
2017-11-04T18:11:58+09:00 #10年後！

TimeSpan のようなクラスを追加すると以下のようになって誤解が少なくなるの
ですが、いかがでしょうか。

> puts Time.now + TimeSpan(:days => 1)
2007-12-28 17:57:40 +0900
> puts Time.now + TimeSpan(:hours => 1)
2007-12-27 18:57:40 +0900
> puts DateTime.now + TimeSpan(:days => 1)
2007-12-28T17:57:40+09:00
> puts DateTime.now + TimeSpan(:hours => 1)
2007-12-27T18:57:40+09:00

-- 
NARUSE, Yui  <naruse@airemix.com>
DBDB A476 FDBD 9450 02CD 0EFC BCE3 C388 472E C1EA

Attachments (1)

timespan.txt (3.38 KB, text/x-diff)

Index: lib/date.rb
===================================================================
--- lib/date.rb	(revision 14733)
+++ lib/date.rb	(working copy)
@@ -1303,6 +1303,7 @@
   # particular, two Dates cannot be added to each other.
   def + (n)
     case n
+    when TimeSpan; return n + self
     when Numeric; return self.class.new!(@ajd + n, @of, @sg)
     end
     raise TypeError, 'expected numeric'
@@ -1318,6 +1319,7 @@
   # If +x+ is neither Numeric nor a Date, a TypeError is raised.
   def - (x)
     case x
+    when TimeSpan; return n - self
     when Numeric; return self.class.new!(@ajd - x, @of, @sg)
     when Date;    return @ajd - x.ajd
     end
@@ -1780,3 +1782,122 @@
   public_class_method  :now
 
 end
+
+
+#
+# = TimeSpan
+#
+# == Examples
+# 
+# Time.now + TimeSpan(:days => 1)
+# Time.now + TimeSpan(:hours => 1)
+# Time.now + TimeSpan(:minutes => 1)
+# DateTime.now + TimeSpan(:days => 1)
+# DateTime.now + TimeSpan(:hours => 1)
+# DateTime.now + TimeSpan(:minutes => 1)
+# 
+def TimeSpan(*arg)
+  TimeSpan.new(*arg)
+end
+
+class TimeSpan
+  #
+  # TimeSpan.new(seconds)
+  # TimeSpan.new(seconds, nanoseconds)
+  # TimeSpan.new(hours, minutes, seconds)
+  # TimeSpan.new(days, hours, minutes, seconds)
+  # TimeSpan.new(days, hours, minutes, seconds, milliseconds)
+  #
+  def initialize(*arg)
+    days = 0; hours = 0; minutes = 0; seconds = 0; milliseconds = 0
+    case arg.length
+    when 1
+      arg = arg.shift
+      case arg
+      when Hash
+	days = arg[:days].to_i if arg[:days]
+	hours = arg[:hours].to_i if arg[:hours]
+	minutes = arg[:minutes].to_i if arg[:minutes]
+	seconds = arg[:seconds].to_i if arg[:seconds]
+	milliseconds = arg[:milliseconds].to_i if arg[:milliseconds]
+      else
+	seconds = arg
+      end
+    when 2
+      seconds, nanoseconds = arg
+    when 3
+      hours, minutes, seconds = arg
+    when 4
+      days, hours, minutes, seconds = arg
+    when 5
+      days, hours, minutes, seconds, milliseconds = arg
+    else
+      raise ArgumentError, 'wrong number of arguments(%d)' % arg.length
+    end
+    @nsec = (((((days * 24 + hours) * 60 + minutes) * 60 + seconds) * 1000 + milliseconds) * 1_000_000).to_i unless @nsec
+    if @nsec >= 0
+      @sign = 1
+    else
+      @sign = -1
+      @nsec = @nsec.abs
+    end
+  end
+  
+  def days
+    @nsec / 86_400_000_000_000 * @sign
+  end
+
+  def hours
+    (@nsec % 86_400_000_000_000) / 3_600_000_000_000 * @sign
+  end
+
+  def minutes
+    (@nsec % 3_600_000_000_000) / 60_000_000_000 * @sign
+  end
+
+  def seconds
+    (@nsec % 60_000_000_000) / 1_000_000_000 * @sign
+  end
+
+  def milliseconds
+    (@nsec % 1_000_000_000) / 1_000_000 * @sign
+  end
+
+  def microseconds
+    (@nsec % 1_000_000) / 1_000 * @sign
+  end
+
+  def nanoseconds
+    (@nsec % 1_000) * @sign
+  end
+
+  def total_seconds
+    Rational(@nsec * @sign, 1_000_000_000)
+  end
+
+  def total_days
+    Rational(@nsec * @sign, 86_400_000_000_000)
+  end
+
+  def to_f
+    @nsec * @sign.to_f / 1_000_000_000
+  end
+
+  def +(other)
+    case other
+    when Time
+      return other + total_seconds
+    when Date
+      return other + total_days
+    end
+  end
+
+  def -(other)
+    case other
+    when Time
+      return other - total_seconds
+    when Date
+      return other - total_days
+    end
+  end
+end

Thread

Prev Next

In This Thread

Prev Next

[#32429] eval("\"\xfd".force_encoding("utf-8")) generages garbage in error message. — Tanaka Akira <akr@...>

[#32430] "wrong number of arguments (6 for 2)" by def m(a, b=:b, c, d, e) — Tanaka Akira <akr@...>

[#32432] eval("a"): illegal multibyte char — Tanaka Akira <akr@...>

[#32434] signature of exit() on C++ — "KISHIMOTO, Makoto" <ksmakoto@...4u.or.jp>

[#32447] ruby 1.9 trunk NKF and KCONV Encoding:ASCII-8BIT — WATANABE Tetsuya <Tetsuya.WATANABE@...>

[#32448] SEGV on "abcd\xf0".force_encoding("utf-8").reverse — Tanaka Akira <akr@...>

[#32451] -e:1:in `conv': no implicit conversion from nil to integer (TypeError) — Tanaka Akira <akr@...>

[#32452] `split': negative string size (or size too big) (ArgumentError) — Tanaka Akira <akr@...>

[#32459] Enumerator raises `dead fiber called' — "Yusuke ENDOH" <mame@...>

[#32462] SEGV by test/ruby/test_fiber.rb — Tanaka Akira <akr@...>

[#32468] Iconv.list patch for NetBSD/Citrus — "NARUSE, Yui" <naruse@...>

[#32473] about to_path and to_open — "Yusuke ENDOH" <mame@...>

[#32475] ext/tk/sample/tkextlib/vu/canvSticker2.rb — Tanaka Akira <akr@...>

[#32485] self-calling method dumps core — Tadashi Saito <shiba@...2.accsnet.ne.jp>

[#32493] Regexp#names, MatchData#names, MatchData#regexp — Tanaka Akira <akr@...>

[#32498] Re: [ruby-cvs:21399] Ruby:r14162 (trunk): * parse.y (expr): redefinable not (!) operator. — SASADA Koichi <ko1@...>

[#32502] :!@.inspect — Kazuhiro NISHIYAMA <zn@...>

[#32509] ruby-core:13961での問題(Error while bulding Ruby 1.9 from snapshot 2007/12/09) — KIMURA Koichi <kimura.koichi@...>

[#32512] Re: [ruby-cvs:21409] Ruby:r14172 (trunk): * transcode.c: new file to provide encoding conversion features. — Nobuyoshi Nakada <nobu@...>

[#32514] typo in lib/uri/common.rb — Ueda Satoshi <s-ueda@...>

[#32518] bug in Array#slice! — Satoshi Nakagawa <snakagawa@...>

[#32531] eigenmethod definition for BasicObjects dumps core — Tadashi Saito <shiba@...2.accsnet.ne.jp>

[#32536] timezone 関数が cygwin で見つかりません — Martin Duerst <duerst@...>

[#32550] Binary String — Hidetoshi NAGAI <nagai@...>

[#32556] default completion for irb1.9 — Tadashi Saito <shiba@...2.accsnet.ne.jp>

[#32563] transcoder loading — Nobuyoshi Nakada <nobu@...>

[#32565] Re: [ruby-cvs:21436] Ruby:r14199 (trunk): * io.c (rb_io_check_readable): set default external encoding to — Tanaka Akira <akr@...>

[#32566] hang with write — Tanaka Akira <akr@...>

[#32567] [nil, [...]] — Tanaka Akira <akr@...>

[#32569] Re: [ruby-cvs:21441] Ruby:r14204 (trunk): * io.c (rb_io_getc): use default external encoding if fptr->enc is — Tanaka Akira <akr@...>

[#32581] expandarray may mark dirty VALUE beyond stack — "Yusuke ENDOH" <mame@...>

[#32585] SEGV by IO.pipe — Tanaka Akira <akr@...>

[#32588] /(?<foo>...)/ =~ str assigns foo — Tanaka Akira <akr@...>

[#32590] Circular dependency on AIX — "Yutaka Kanemoto" <kinpoco@...>

[#32604] stack overflow by GC in a thread — Tanaka Akira <akr@...>

[#32606] encoding loading — Nobuyoshi Nakada <nobu@...>

[#32608] $! == 8 — Tanaka Akira <akr@...>

[#32609] Re: [ruby-cvs:21475] Ruby:r14238 (trunk): * configure.in (enc/Makefile): add external encoding objects list. — Yukihiro Matsumoto <matz@...>

[#32610] 1.9.1 issues left (as of 12/15) — Yukihiro Matsumoto <matz@...>

[#32622] binding of caller — Nobuyoshi Nakada <nobu@...>

[#32624] rss and base64 — Tanaka Akira <akr@...>

[#32625] Re: [ruby-cvs:21528] Ruby:r14292 (trunk): more tests. — Yukihiro Matsumoto <matz@...>

[#32628] Bignum#to_s doesn't check base — "Yusuke ENDOH" <mame@...>

[#32629] faster Bignum#* — "Yusuke ENDOH" <mame@...>

[#32631] Cygwin 上で Ruby最新版 をインストールする場合 — "Koji Tominaga" <crimsonshower@...>

[#32636] Re: [ruby-cvs:21552] Ruby:r14315 (trunk): * ext/nkf/nkf.c (NKF::_ENCODING): removed. — Tanaka Akira <akr@...>

[#32640] inspect closed dir. — Tanaka Akira <akr@...>

[#32641] interrupt in * — Tanaka Akira <akr@...>

[#32644] unparenthesized method call with block — "Yusuke ENDOH" <mame@...>

[#32645] unparenthesized method call with block — "Yusuke ENDOH" <mame@...>

[#32662] encode! は変換しないときに <nil> になってしまう。 — Martin Duerst <duerst@...>

[#32665] Net::POP3#enable_sslの仕様変更 — Shugo Maeda <shugo@...>

[#32668] syntax errors on ext/tk/sample — "U.Nakamura" <usa@...>

[#32675] /(?<break>a)/ =~ "a" 等によるローカル変数 — "Keita Yamaguchi" <keita.yamaguchi@...>

[#32677] nil.freeze in date.rb — Shugo Maeda <shugo@...>

[#32680] fail to compile version.c in trunk — Masaki Suketa <masaki.suketa@...>

[#32685] test/webrick/test_server.rb hang — Tanaka Akira <akr@...>

[#32686] enum_inject の説明文 — "Keita Yamaguchi" <keita.yamaguchi@...>

[#32687] Re: [ruby-cvs:21753] Ruby:r14516 (trunk): * lib/time.rb (Time.httpdate): use Time.utc for — Tadayoshi Funaba <tadf@...>

[#32691] Why only inject() accepts :symbols as if it's a Proc in Enumerable? — Tadashi Saito <shiba@...2.accsnet.ne.jp>

[#32693] String#== is not transitive — Tanaka Akira <akr@...>

[#32695] ISO-2022-JP output for transcode — "NARUSE, Yui" <naruse@...>

[#32699] cygwin 上で r14576 現在の test の失敗 — Martin Duerst <duerst@...>

[#32706] Fwd: RDoc: [FATAL] failed to allocate memory — Martin Duerst <duerst@...>

[#32708] Enumerable can't take multiple parameters — GOTOU Yuuzou <gotoyuzo@...>

[#32709] Re: [ruby-cvs:21826] Ruby:r14589 (trunk): Mon Dec 24 17:20:34 2007 NAKAMURA, Hiroshi <nahi@ruby-lang.org> — Tadayoshi Funaba <tadf@...>

[#32710] \e — "U.Nakamura" <usa@...>

[#32713] pre-release note for the christmas release. — Yukihiro Matsumoto <matz@...>

[#32715] issues left as of 12/25 2:00am JST — Yukihiro Matsumoto <matz@...>

[#32718] next dumps core when poped is 0 — "Yusuke ENDOH" <mame@...>

[#32725] more ANSI'ize — Tadashi Saito <shiba@...2.accsnet.ne.jp>

[#32726] Can't build on MacOSX 10.4(Tiger) (was Re: Re: 1.9.1 issues left (as of 12/15)) — "MOROHASHI Kyosuke" <moronatural@...>

[#32740] distinguish "w" and "w:euc-jp" — Tanaka Akira <akr@...>

[#32746] appendline Invalid read of size 1 — Tanaka Akira <akr@...>

[#32747] test-all on Debian/GNU etch — SASADA Koichi <ko1@...>

[#32748] resut of make test on cygwin — SASADA Koichi <ko1@...>

[#32756] make rdoc cause segv on OpenBSD — SASADA Koichi <ko1@...>

[#32763] Re: [ruby-cvs:21913] Ruby:r14676 (trunk): * trunk/common.mk, goruby.c, golf_prelude.rb: for golfers. — Yukihiro Matsumoto <matz@...>

[#32765] test/ruby/test_transcode.rb の問題 — Martin Duerst <duerst@...>

[#32767] result of test-all on FreeBSD 6.2 — SASADA Koichi <ko1@...>

[#32631] Cygwin 上で Ruby最新版をインストールする場合 — "Koji Tominaga" <crimsonshower@...>