From: ruby-core@...
Date: 2020-04-12T06:27:27+00:00
Subject: [ruby-core:97847] [Ruby master Bug#16776] Regression in coverage	library

Issue #16776 has been updated by marcandre (Marc-Andre Lafortune).


I'm not super familiar with `TracePoint`, but at first sight `DeepCover` shouldn't generate any extra callbacks as the instrumenting is minimal, typically adding `$tracker[42] += 1` and taking care to never change the line numbers.

So it should work even with `TracePoint` enabled and shouldn't impact your tests. I tested quickly with DeepCover's clone mode and confirm that your test suite appear to pass :-)

----------------------------------------
Bug #16776: Regression in coverage library
https://bugs.ruby-lang.org/issues/16776#change-85071

* Author: deivid (David Rodr�guez)
* Status: Open
* Priority: Normal
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
Hi!

I noticed a regression in the coverage library. I tried to write a minimal program to show it, hopefully it gives some clues or where the issue might lie.

In ruby 2.5.8 and earlier, the following program would print `{:lines=>[1, 1, nil]}`, showing that the body of the "foo" method was run once. However, on newer rubies, it prints `{:lines=>[1, 0, nil]}`, which is incorrect because the "foo" method body has actually been run once.

This is the repro script:

```ruby
# frozen_string_literal: true

require "coverage"
Coverage.start(lines: true)

code = <<~RUBY
  def foo
    "LOL"
  end
RUBY

File.open("foo.rb", "w") { |f| f.write(code) }

require_relative "foo"

TracePoint.new(:line) do |_tp|
  foo
end.enable do
  sleep 0
end

res = Coverage.result
puts res[File.expand_path("foo.rb")]
```




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>