[ruby-core:95701] [Ruby master Feature#14430] net/http: use Socket.tcp with connect_timeout, instead of TCPSocket.open wrapped in Timeout.timeout
From:
jean.boussier@...
Date:
2019-11-05 13:32:48 UTC
List:
ruby-core #95701
Issue #14430 has been updated by byroot (Jean Boussier). We've been recently bitten by this. Does the merge of [#15553] makes https://github.com/ruby/ruby/pull/1806 functional? ---------------------------------------- Feature #14430: net/http: use Socket.tcp with connect_timeout, instead of TCPSocket.open wrapped in Timeout.timeout https://bugs.ruby-lang.org/issues/14430#change-82488 * Author: carl.hoerberg (Carl Hberg) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- Instead of using TCPSocket.open, wrapped in Timeout.timeout, that will create a temporary thread. By using Socket.tcp with the connect_timeout argument for open_timeout the connection opening is much more efficient as the kernels timeout is used instead. PR at: https://github.com/ruby/ruby/pull/1806 -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>