From: naruse@... Date: 2019-08-20T12:47:40+00:00 Subject: [ruby-core:94445] [Ruby master Bug#9115] Logger traps all exceptions; breaks Timeout Issue #9115 has been updated by naruse (Yui NARUSE). There're also rescue-clauses for `check_shift_log` and `@dev.write(message)`. They may raise various exceptions and logger.rb never knows that. Explicitly passing those exceptions are general way, but are there any exceptions other than the family of Timeout::Error? ---------------------------------------- Bug #9115: Logger traps all exceptions; breaks Timeout https://bugs.ruby-lang.org/issues/9115#change-80871 * Author: cphoenix (Chris Phoenix) * Status: Assigned * Priority: Normal * Assignee: sonots (Naotoshi Seo) * Target version: * ruby -v: ruby 2.0.0p247 (2013-06-27) [i386-mingw32] * Backport: ---------------------------------------- Line 577-579 of logger.rb rescue Exception => ignored warn("log writing failed. #{ignored}") end Thus, when the system times out in the middle of writing a log message, it warns "log writing failed. execution expired" and just keeps right on running. This is true in 1.9.3 as well. I haven't looked at older versions. Pardon me while I go grep "rescue Exception" in the entire Ruby codebase, and see whether I can reliably use Timeout at all... OK, you might check out C:\Ruby200\lib\ruby\gems\2.0.0\gems\activerecord-3.2.13\lib\active_record\railties\databases.rake All the other "rescue Exception" seem to re-raise it, except maybe C:\Ruby200\lib\ruby\2.0.0\xmlrpc\server.rb and C:\Ruby200\lib\ruby\gems\2.0.0\gems\activesupport-3.2.13\lib\active_support\callbacks.rb -- https://bugs.ruby-lang.org/ Unsubscribe: