From: nagachika00@... Date: 2018-06-19T12:10:48+00:00 Subject: [ruby-core:87520] [Ruby trunk Bug#14846][Closed] Backport fixes for Kernel#warn(uplevel:) Issue #14846 has been updated by nagachika (Tomoyuki Chikanaga). Status changed from Open to Closed Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED Thank you for your notice. I will backport r63650. ---------------------------------------- Bug #14846: Backport fixes for Kernel#warn(uplevel:) https://bugs.ruby-lang.org/issues/14846#change-72523 * Author: Eregon (Benoit Daloze) * Status: Closed * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] * Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED ---------------------------------------- ~~~ ruby -> { warn("foo", 100) }.should output(nil, "warning: foo\n") ~~~ It is missing the "warning: " prefix in 2.5.1. ~~~ ruby -> { warn "", uplevel: -1 }.should raise_error(ArgumentError) ~~~ It doesn't raise in 2.5.1 even though `warn "", uplevel: -2` does. Both were fixed on trunk. I believe it should be fixed in 2.5 as that is buggy behavior. Then https://github.com/ruby/spec/commit/dea70b1c50f2cba7624b764fea639edfcff11ced can be reverted. -- https://bugs.ruby-lang.org/ Unsubscribe: