[ruby-core:85033] [Ruby trunk Bug#14246] Inconsistent C source code indentation

Issue #14246 has been updated by shyouhei (Shyouhei Urabe).


We discussed this issue in today's developer meeting.

- We agreed _not_ to batch update the indents at once.  Indents should become consistent occasionally.
- Matz has no strong opinion on this topic.
- We agreed to move to spaces only.  Reasons behind this:
    - No contemporary advantage of mixing tabs and spaces today.
    - Emacs fans at the meeting could use ruby-style.el, and that style can be updated.

So the next action is:

- Modify ruby-style.el and other config files.
- Use them.

----------------------------------------
Bug #14246: Inconsistent C source code indentation
https://bugs.ruby-lang.org/issues/14246#change-69744

* Author: shyouhei (Shyouhei Urabe)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
I would like to focus on following 238 C source codes in our repository.

```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | wc -l
238
```

Here, in these 238 files, 10 files are indented using spaces only.

```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \
xargs grep --files-without-match $'^\t' | xargs grep --files-with-match '^        ' | wc -l
10
```

On the other hand 66 files are indented using tabs.

```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \
xargs grep --files-with-match $'^\t' | xargs grep --files-without-match '^        ' | wc -l
66
```

Other 61 files do not indent.  We should not bother them.

```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \
xargs grep --files-without-match $'^\t' | xargs grep --files-without-match '^        ' | wc -l
61
```

So far so good.  But what about remaining 101 files?  The answer is obvious; these files MIX indents.

```
% git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \
xargs grep --files-with-match $'^\t' | xargs grep --files-with-match '^        ' | wc -l
101
```

This is totally wrong.  No matter should we use spaces or tabs for indentations, it must be consistent.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>