From: duerst@... Date: 2016-12-24T04:13:20+00:00 Subject: [ruby-core:78818] [Ruby trunk Feature#12979] Avoid exception for #dup on Integer (and similar cases) Issue #12979 has been updated by Martin D��rst. Mike Vastola wrote: > So, looking at this more closely, I'm beginning to think this issue was closed in error. The original issue has indeed been fixed, and so 'closed' is correct: ``` $ ruby -v ruby 2.4.0dev (2016-12-24 trunk 57168) [x86_64-cygwin] $ ruby -e 'puts 1.dup' 1 ``` The main fix was at r56906. If you think additional improvements are needed, please open a new issue (and reference this one). ---------------------------------------- Feature #12979: Avoid exception for #dup on Integer (and similar cases) https://bugs.ruby-lang.org/issues/12979#change-62222 * Author: Martin D��rst * Status: Closed * Priority: Normal * Assignee: Nobuyoshi Nakada * Target version: ---------------------------------------- This is a proposal resulting from a discussion in Bug #11929. Because this is proposing a different solution from #11929, it has a new number. #11929 shows that people are confused that e.g. 3.dup throws an exception (but Integer#dup is actually implemented, so Integer.respond_to? :dup => true). Integer#dup should fail silently, returning the receiver, in the same way as Integer#freeze fails silently. Citing from #11929 (comment by Mike Vastola): "If the object can't be duped/cloned because it's an immediate, dup/clone should return the object itself. (There shouldn't be any harm in doing so since nothing about the object can be changed in the first place.)". Citing some more: > I literally can't imagine any scenario in which a dev, when, say, coding a class with the line: > > return val.dup.freeze > .. really wants an Exception thrown when val happens to be de-facto un-dup-able. What they really want is: > > return val.dup.freeze rescue val The proposal also has the advantage that it leads to a much more unified, streamlined protocol, avoiding needless exposition of internals. It would do exactly what dup (and clone) are described to do, namely (pretend to) return a shallow copy. -- https://bugs.ruby-lang.org/ Unsubscribe: