From: naruse@...
Date: 2016-12-12T18:02:42+00:00
Subject: [ruby-core:78617] [Ruby trunk Bug#9974][Rejected] Regression: URI.parse allows invalid URIs

Issue #9974 has been updated by Yui NARUSE.

Status changed from Open to Rejected

Larry Kyrala wrote:
> The URI abstraction speaks to RFC3986 (DNS) more directly than RFC952 (hostnames).  The confusion is understandable.
> 
> Still, standards-based systems exist right now that allow this (e.g. we have an nginx deployed application that chose an underscore 4th-level name, but it works every place else).
> 
> But any Ruby clients that attempt to integrate against this endpoint fail.  This puts Ruby at a disadvantage.  I'd argue that the existence of Python/Java solutions etc. may not be 'legal', but is at least 'de facto'.

JavaScript's `new URL("http://test_example")` accepts underscore.
Therefore I don't think error is de facto.

----------------------------------------
Bug #9974: Regression: URI.parse allows invalid URIs
https://bugs.ruby-lang.org/issues/9974#change-62002

* Author: Gabriel Gilder
* Status: Rejected
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.2.0dev (2014-06-23 trunk 46517) [x86_64-darwin13]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
~~~
$ ruby -v
ruby 2.2.0dev (2014-06-23 trunk 46517) [x86_64-darwin13]
$ ruby -ruri -e "puts URI.parse('http://test_example')"
http://test_example
~~~

Compare to Ruby 2.1.2:

~~~
$ ruby -v
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]
$ ruby -ruri -e "puts URI.parse('http://test_example')"
/Users/gabriel/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/uri/generic.rb:214:in `initialize': the scheme http does not accept registry part: test_example (or bad hostname?) (URI::InvalidURIError)
        from /Users/gabriel/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/uri/http.rb:84:in `initialize'
        from /Users/gabriel/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/uri/common.rb:214:in `new'
        from /Users/gabriel/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/uri/common.rb:214:in `parse'
        from /Users/gabriel/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/uri/common.rb:747:in `parse'
        from -e:1:in `<main>'
~~~

This appears to be a regression as hostnames cannot legally contain underscores: http://en.wikipedia.org/wiki/Hostname#Restrictions%5Fon%5Fvalid%5Fhost%5Fnames





-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>