ruby-core

Mailing list archive

[ruby-core:67091] [ruby-trunk - Bug #10623] rb_hash_delete() can return Qundef in 2.2-rc1

From: nagachika00@...
Date: 2014-12-24 03:14:20 UTC
List: ruby-core #67091
Issue #10623 has been updated by Tomoyuki Chikanaga.

Backport changed from 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: REQUIRED to 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED

I didn't confirm it by myyself, but r48114 was already backported into ruby_2_1/ruby_2_0_0. So this should be backported into them too.

----------------------------------------
Bug #10623: rb_hash_delete() can return Qundef in 2.2-rc1
https://bugs.ruby-lang.org/issues/10623#change-50604

* Author: Aman Gupta
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: current: 2.2.0
* ruby -v: ruby 2.2.0dev [x86_64-darwin14]
* Backport: 2.0.0: REQUIRED, 2.1: REQUIRED, 2.2: REQUIRED
----------------------------------------
The behavior of rb_hash_delete() has changed from 2.1. Before, it would always return Qnil or VALUE. Now it can also return Qundef, which is breaking the posix-spawn gem's usage:

https://github.com/rtomayko/posix-spawn/blob/master/ext/posix-spawn.c#L242-L258

It also appears RTEST(Qundef) returns true, which causes a segfault in posix-spawn gem here:

https://github.com/rtomayko/posix-spawn/blob/master/ext/posix-spawn.c#L425

I think we should revert back to original behavior before 2.2.0 is released.



-- 
https://bugs.ruby-lang.org/

In This Thread

Prev Next