From: Jeffrey 'jf' Lim <jfs.world@...>
Date: 2014-07-31T18:09:26+08:00
Subject: [ruby-core:64138] Re: Ruby 2.1.2 (and 2.1.1 and probably others) assumes a libffi with 3 version numbers in extconf.rb

--047d7bf10adeb1fb9604ff7a7721
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Jul 31, 2014 at 6:03 PM, Jeffrey 'jf' Lim <jfs.world@gmail.com>
wrote:

> As per subject.
>
> If you have the latest libffi version (3.1) installed, fiddle wont be
> configured.
>
> The offending section in extconf.rb:
> ========
>   7 pkg_config("libffi")
>   8 if ver = pkg_config("libffi", "modversion")
>   9   ver = ver.gsub(/-rc\d+/, '') # If ver contains rc version, just
> ignored.
>  10   $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ '%d%03d' % ver.split('.')
> }})
>  11 end
> ========
>
> I'm not too sure what the idiomatic approach would be; how about the
> following?
>
> ===============
> --- ext/fiddle/extconf.rb.orig    2013-05-19 10:42:16.000000000 +0800
> +++ ext/fiddle/extconf.rb    2014-07-31 18:00:47.000000000 +0800
> @@ -7,7 +7,8 @@
>  pkg_config("libffi")
>  if ver = pkg_config("libffi", "modversion")
>    ver = ver.gsub(/-rc\d+/, '') # If ver contains rc version, just ignored.
> -  $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ '%d%03d%03d' % ver.split('.')
> }})
> +  ver_split = ver.split('.')
> +  $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ ('%d' +
> '%03d'*(versplit.length-1)) % versplit }})
>  end
>
>  unless have_header('ffi.h')
> =================
>
>

or indeed the "correct" way? Do we use/assume "3.1.0" for "3.1" instead,
for example?

-jf

--047d7bf10adeb1fb9604ff7a7721
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Thu, Jul 31, 2014 at 6:03 PM, Jeffrey &#39;jf&#39; Lim =
<span dir=3D"ltr">&lt;<a href=3D"mailto:jfs.world@gmail.com" target=3D"_bla=
nk">jfs.world@gmail.com</a>&gt;</span> wrote:<br><div class=3D"gmail_extra"=
><div class=3D"gmail_quote">

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div><div><div><div><div><div>As per subject=
.<br><br></div>If you have the latest libffi version (3.1) installed, fiddl=
e wont be configured.<br>

<br></div>The offending section in extconf.rb:<br>=3D=3D=3D=3D=3D=3D=3D=3D<=
br>=A0 7 pkg_config(&quot;libffi&quot;)<br>
=A0 8 if ver =3D pkg_config(&quot;libffi&quot;, &quot;modversion&quot;)<br>=
=A0 9=A0=A0 ver =3D ver.gsub(/-rc\d+/, &#39;&#39;) # If ver contains rc ver=
sion, just ignored.<br>=A010=A0=A0 $defs.push(%{-DRUBY_LIBFFI_MODVERSION=3D=
#{ &#39;%d%03d&#39; % ver.split(&#39;.&#39;) }})<br>


=A011 end<br>=3D=3D=3D=3D=3D=3D=3D=3D<br><br></div><div>I&#39;m not too sur=
e what the idiomatic approach would be; how about the following?<br><br>=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br>--- ext/fiddle/extconf.rb.ori=
g=A0=A0=A0 2013-05-19 10:42:16.000000000 +0800<br>


+++ ext/fiddle/extconf.rb=A0=A0=A0 2014-07-31 18:00:47.000000000 +0800<br>@=
@ -7,7 +7,8 @@<br>=A0pkg_config(&quot;libffi&quot;)<br>=A0if ver =3D pkg_co=
nfig(&quot;libffi&quot;, &quot;modversion&quot;)<br>=A0=A0 ver =3D ver.gsub=
(/-rc\d+/, &#39;&#39;) # If ver contains rc version, just ignored.<br>


-=A0 $defs.push(%{-DRUBY_LIBFFI_MODVERSION=3D#{ &#39;%d%03d%03d&#39; % ver.=
split(&#39;.&#39;) }})<br>+=A0 ver_split =3D ver.split(&#39;.&#39;)<br>+=A0=
 $defs.push(%{-DRUBY_LIBFFI_MODVERSION=3D#{ (&#39;%d&#39; + &#39;%03d&#39;*=
(versplit.length-1)) % versplit }})<br>


=A0end<br>=A0<br>=A0unless have_header(&#39;ffi.h&#39;)<br>=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D<br></div><div>=A0</div></div></div></d=
iv></blockquote><div><br></div><div>or indeed the &quot;correct&quot; way? =
Do we use/assume &quot;3.1.0&quot; for &quot;3.1&quot; instead, for example=
?<br>

<br>-jf<br><br></div></div></div></div>

--047d7bf10adeb1fb9604ff7a7721--