[ruby-core:64138] Re: Ruby 2.1.2 (and 2.1.1 and probably others) assumes a libffi with 3 version numbers in extconf.rb

On Thu, Jul 31, 2014 at 6:03 PM, Jeffrey 'jf' Lim <[e-mail]>
wrote:

> As per subject.
>
> If you have the latest libffi version (3.1) installed, fiddle wont be
> configured.
>
> The offending section in extconf.rb:
> ========
>   7 pkg_config("libffi")
>   8 if ver = pkg_config("libffi", "modversion")
>   9   ver = ver.gsub(/-rc\d+/, '') # If ver contains rc version, just
> ignored.
>  10   $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ '%d%03d' % ver.split('.')
> }})
>  11 end
> ========
>
> I'm not too sure what the idiomatic approach would be; how about the
> following?
>
> ===============
> --- ext/fiddle/extconf.rb.orig    2013-05-19 10:42:16.000000000 +0800
> +++ ext/fiddle/extconf.rb    2014-07-31 18:00:47.000000000 +0800
> @@ -7,7 +7,8 @@
>  pkg_config("libffi")
>  if ver = pkg_config("libffi", "modversion")
>    ver = ver.gsub(/-rc\d+/, '') # If ver contains rc version, just ignored.
> -  $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ '%d%03d%03d' % ver.split('.')
> }})
> +  ver_split = ver.split('.')
> +  $defs.push(%{-DRUBY_LIBFFI_MODVERSION=#{ ('%d' +
> '%03d'*(versplit.length-1)) % versplit }})
>  end
>
>  unless have_header('ffi.h')
> =================
>
>

or indeed the "correct" way? Do we use/assume "3.1.0" for "3.1" instead,
for example?

-jf