From: shibata.hiroshi@... Date: 2014-01-30T06:16:28+00:00 Subject: [ruby-core:60260] [ruby-trunk - Bug #4352] [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s) Issue #4352 has been updated by Hiroshi SHIBATA. Target version changed from 2.1.0 to current: 2.2.0 ---------------------------------------- Bug #4352: [patch] Fix eval(s, b) backtrace; make eval(s, b) consistent with eval(s) https://bugs.ruby-lang.org/issues/4352#change-44737 * Author: James M. Lawrence * Status: Assigned * Priority: Normal * Assignee: Yukihiro Matsumoto * Category: core * Target version: current: 2.2.0 * ruby -v: ruby 1.9.3dev (2011-02-01 trunk 30751) [i386-darwin9.8.0] * Backport: ---------------------------------------- =begin def ex_message begin yield rescue => e p e.message end end ex_message { eval('raise') } ex_message { eval('raise', binding) } eval('def f ; end') p method(:f).source_location eval('def g ; end', binding) p method(:g).source_location ---- Without patch: "(eval):1:in `block in
': " "" ["(eval)", 1] ["eval_test.rb", 14] With patch: "(eval):1:in `block in
': " "(eval):1:in `block in
': " ["(eval)", 1] ["(eval)", 1] Knowing the line of an error inside eval is useful. Passing a binding shouldn't discard that information. Present behavior is even wrong: there's no line 10 in this file. ---- eval %{ # .. code ... raise }, binding ---- Without patch: /Users/jlawrence/tmp/raiser.rb:10:in `
': unhandled exception from /Users/jlawrence/tmp/raiser.rb:7:in `eval' from /Users/jlawrence/tmp/raiser.rb:7:in `
' With patch: /Users/jlawrence/tmp/raiser.rb:7:in `eval': (eval):4:in `
': (RuntimeError) from /Users/jlawrence/tmp/raiser.rb:7:in `eval' from /Users/jlawrence/tmp/raiser.rb:7:in `
' =end ---Files-------------------------------- eval.patch (1.75 KB) -- http://bugs.ruby-lang.org/