From: charliesome@...
Date: 2014-01-27T23:56:32+00:00
Subject: [ruby-core:60147] [ruby-trunk - Bug #9455] [Closed] Blocks do not round-trip properly through ISeq dump/load

Issue #9455 has been updated by Charlie Somerville.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r44720.

----------
compile.c: use correct key for block when loading serialized iseqs

* compile.c (iseq_build_from_ary_body): Use :blockptr instead of :block
  as hash key when loading serialized instruction sequences from arrays.
  [Bug #9455] [ruby-core:60146]

----------------------------------------
Bug #9455: Blocks do not round-trip properly through ISeq dump/load
https://bugs.ruby-lang.org/issues/9455#change-44640

* Author: Charlie Somerville
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: trunk
* Backport: 1.9.3: DONTNEED, 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
Blocks passed to methods do not round-trip properly when dumped with RubyVM::InstructionSequence#to_a and then loaded again with rb_iseq_load.

This is because iseq_data_to_ary in iseq.c stores serialized blocks under the :blockptr key (https://github.com/ruby/ruby/blob/trunk/iseq.c#L1813), but expects them to be stored in the :block key when loading them back up (https://github.com/ruby/ruby/blob/trunk/compile.c#L5811).

This affects trunk, 2.1.0 and 2.0.0.



-- 
http://bugs.ruby-lang.org/