From: KOSAKI Motohiro Date: 2013-12-05T17:37:16-05:00 Subject: [ruby-core:58882] Re: [ruby-trunk - Feature #5446] at_fork callback API 2013/11/30 tmm1 (Aman Gupta) : > > Issue #5446 has been updated by tmm1 (Aman Gupta). > > > Simple implementation of an after_fork{} hook: https://github.com/tmm1/ruby/commit/711a68b6599d176c5bcb4ef0c90aa195a290d1c0 > > Any objection? ??!?!? 1. Why no before_fork? 2. zk has :after_child nad :after_parent hook and your patch don't. Why? 3. Why should the new method return proc? 4. When rb_daemon() is used, some platform call after_fork once and the other call twice. It seems useless. 5. Why do hook fire at rb_thread_atfork() make a lot of new array? 6. Your patch doesn't aim to remove the hooks and I'm sure it is required. You said the new method should be created for killing the gem specific hooks. But your patch seems not to be able to.