From: "drbrain (Eric Hodel)" <drbrain@...7.net>
Date: 2013-11-20T08:27:54+09:00
Subject: [ruby-core:58439] [ruby-trunk - Bug #9129][Assigned] Regression in	support for IPv6 literals in URIs with Net::HTTP


Issue #9129 has been updated by drbrain (Eric Hodel).

Category set to lib
Status changed from Open to Assigned
Assignee set to naruse (Yui NARUSE)
Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: DONTNEED, 2.0.0: UNKNOWN

=begin
I can't find a regression here as no prior version has #proxy_uri:

  $ ruby19 -v -rnet/http -e 'Net::HTTP.new("::1", 80).proxy_uri'
  ruby 1.9.3p374 (2013-01-15 revision 38858) [x86_64-darwin12.2.1]
  -e:1:in `<main>': undefined method `proxy_uri' for #<Net::HTTP ::1:80 open=false> (NoMethodError)

IIRC net/http has always required square brackets for IPv6 addresses:

  $ ruby -v -rnet/http -e 'Net::HTTP.new("[::1]", 80).proxy_uri'
  ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.4.0]
  $

This is consistent with URI:

  $ ruby -ruri -e 'u = URI "http://[::1]"; u.host = "[::2]"; puts u'
  http://[::2]
  $ ruby -ruri -e 'u = URI "http://[::1]"; u.host = "::2"; puts u'
  [���]/uri/generic.rb:605:in `check_host': bad component(expected host component): ::2 (URI::InvalidComponentError)

If you are using URI to figure out the host portion, use #host, not #hostname:

  $ ruby -ruri -e 'u = URI "http://[::1]"; p u.host, u.hostname'
  "[::1]"
  "::1"

See also the URI::HTTP#host and #hostname documentation.

I have assigned this to naruse as he is Net::HTTP maintainer, maybe I am wrong.

=end
----------------------------------------
Bug #9129: Regression in support for IPv6 literals in URIs with Net::HTTP
https://bugs.ruby-lang.org/issues/9129#change-43037

Author: kallistec (Daniel DeLeo)
Status: Assigned
Priority: Normal
Assignee: naruse (Yui NARUSE)
Category: lib
Target version: 
ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.4.0]
Backport: 1.9.3: DONTNEED, 2.0.0: UNKNOWN


The proxy code in Net::HTTP constructs a URI string by concatenating the address with the port. If the address is IPv6, this is incorrect, the address should be surrounded by square brackets. My code is failing in the Net::HTTP#proxy_uri method. The error can be reproduced by:

ruby -r'net/http' -e 'Net::HTTP.new("::1", 80).proxy_uri'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/generic.rb:214:in `initialize': the scheme http does not accept registry part: ::1:80 (or bad hostname?) (URI::InvalidURIError)
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/http.rb:84:in `initialize'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `new'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `parse'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:747:in `parse'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:994:in `URI'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1027:in `proxy_uri'
	from -e:1:in `<main>'


Though I've not tried to reproduce on current trunk, the implementation of Net::HTTP#proxy_uri is unchanged from 2.0.0p0 and current trunk.

My application's tests pass if I monkey patch that method as follows:

      def proxy_uri # :nodoc:
        ipv6_safe_addr = address.to_s.include?(":") ? "[#{address}]" : address
        @proxy_uri ||= URI("http://#{ipv6_safe_addr}:#{port}").find_proxy
      end



-- 
http://bugs.ruby-lang.org/