From: Txus <josep.m.bach@...>
Date: 2013-11-19T09:09:21+01:00
Subject: [ruby-core:58422] Re: [ruby-trunk - Feature #9123] Make Numeric#nonzero? behavior consistent with Numeric#zero?

--047d7b33d548cb153504eb832ff8
Content-Type: text/plain; charset=UTF-8

Whereas the current implementation "works" as a predicate, I see no harm in
gradually polishing Ruby towards a better design. If one was to design that
from scratch, I bet there'd be no discussion -- predicates would return
either true or false.

I would love to see more of these kind of patches getting accepted.

--
Txus
(I'll be slowly moving off this address -- please contact me at
me@txus.ioif possible from now on.)


On Tue, Nov 19, 2013 at 2:32 AM, sferik (Erik Michaels-Ober) <
sferik@gmail.com> wrote:

>
> Issue #9123 has been updated by sferik (Erik Michaels-Ober).
>
>
> I did not remove that example, I just moved it under the documentation for
> Numeric#nonzero.
> ----------------------------------------
> Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?
> https://bugs.ruby-lang.org/issues/9123#change-43012
>
> Author: sferik (Erik Michaels-Ober)
> Status: Open
> Priority: Normal
> Assignee:
> Category:
> Target version:
>
>
> Numeric#zero? returns true or false, while Numeric#nonzero? returns self
> or nil.
>
> I've written a patch that fixes this inconsistency and adds a
> Numeric#nonzero (non-predicate) method that returns self or nil for
> chaining comparisons. I'd like for this to be included in Ruby 2.1.0.
>
> https://github.com/ruby/ruby/pull/452.patch
>
>
> --
> http://bugs.ruby-lang.org/
>

--047d7b33d548cb153504eb832ff8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Whereas the current implementation &quot;works&quot; =
as a predicate, I see no harm in gradually polishing Ruby towards a better =
design. If one was to design that from scratch, I bet there&#39;d be no dis=
cussion -- predicates would return either true or false.<br>

<br></div>I would love to see more of these kind of patches getting accepte=
d.<br></div><div class=3D"gmail_extra"><br clear=3D"all"><div><div dir=3D"l=
tr"><div><div>--<br></div>Txus<br></div>(I&#39;ll be slowly moving off this=
 address -- please contact me at <a href=3D"mailto:me@txus.io" target=3D"_b=
lank">me@txus.io</a> if possible from now on.)<br>

 </div></div>
<br><br><div class=3D"gmail_quote">On Tue, Nov 19, 2013 at 2:32 AM, sferik =
(Erik Michaels-Ober) <span dir=3D"ltr">&lt;<a href=3D"mailto:sferik@gmail.c=
om" target=3D"_blank">sferik@gmail.com</a>&gt;</span> wrote:<br><blockquote=
 class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli=
d;padding-left:1ex">

<br>
Issue #9123 has been updated by sferik (Erik Michaels-Ober).<br>
<br>
<br>
I did not remove that example, I just moved it under the documentation for =
Numeric#nonzero.<br>
<div class=3D"im">----------------------------------------<br>
Feature #9123: Make Numeric#nonzero? behavior consistent with Numeric#zero?=
<br>
</div><a href=3D"https://bugs.ruby-lang.org/issues/9123#change-43012" targe=
t=3D"_blank">https://bugs.ruby-lang.org/issues/9123#change-43012</a><br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
Author: sferik (Erik Michaels-Ober)<br>
Status: Open<br>
Priority: Normal<br>
Assignee:<br>
Category:<br>
Target version:<br>
<br>
<br>
Numeric#zero? returns true or false, while Numeric#nonzero? returns self or=
 nil.<br>
<br>
I&#39;ve written a patch that fixes this inconsistency and adds a Numeric#n=
onzero (non-predicate) method that returns self or nil for chaining compari=
sons. I&#39;d like for this to be included in Ruby 2.1.0.<br>
<br>
<a href=3D"https://github.com/ruby/ruby/pull/452.patch" target=3D"_blank">h=
ttps://github.com/ruby/ruby/pull/452.patch</a><br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
</div></div></blockquote></div><br></div>

--047d7b33d548cb153504eb832ff8--