ruby-core

Issue #9089 has been updated by akr (Akira Tanaka).

Status changed from Open to Feedback
Assignee deleted (akr (Akira Tanaka))

As far as I know, NUM2Uxxx accepts negative integers. 
For consistency, FIX2Uxxx should behaves so.

Also, both r40028 and r40029 behaves same for
r40028/bin/ruby rubyspec/optional/capi/fixnum_spec.rb.

So r40029 doesn't change the behavior.

% svn log -r r40029 
------------------------------------------------------------------------
r40029 | akr | 2013-04-01 12:06:09 +0900 (Mon, 01 Apr 2013) | 4 lines

* numeric.c (check_uint): Take the 1st argument as unsigned long,
  instead of VALUE.  Refine the validity test conditions.
  (check_ushort): Ditto.

------------------------------------------------------------------------
% ./r40028/bin/ruby -v
ruby 2.1.0dev (2013-04-01 trunk 40028) [x86_64-linux]
% ./r40029/bin/ruby -v
ruby 2.1.0dev (2013-04-01 trunk 40029) [x86_64-linux]

% ruby mspec/bin/mspec -t r40028/bin/ruby rubyspec/optional/capi/fixnum_spec.rb
ruby 2.1.0dev (2013-04-01 trunk 40028) [x86_64-linux]
.F.............

1)
CApiFixnumSpecs rb_fix2uint raises a RangeError when given a negative value FAILED
Expected RangeError but no exception was raised (-1 was returned)
/home/akr/fix2int/mspec/lib/mspec/expectations/expectations.rb:15:in `fail_with'
/home/akr/fix2int/mspec/lib/mspec/expectations/should.rb:8:in `should'
/home/akr/fix2int/rubyspec/optional/capi/fixnum_spec.rb:17:in `block (4 levels) in <top (required)>'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `instance_eval'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `block in protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `all?'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:208:in `block (2 levels) in process'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:239:in `block in repeat'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:238:in `times'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:238:in `repeat'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:200:in `block in process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:199:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:199:in `process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `block in process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `process'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:38:in `describe'
/home/akr/fix2int/mspec/lib/mspec/runner/object.rb:11:in `describe'
/home/akr/fix2int/rubyspec/optional/capi/fixnum_spec.rb:5:in `<top (required)>'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `load'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `block (2 levels) in files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `instance_eval'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `block in files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:51:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:51:in `files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:43:in `process'
/home/akr/fix2int/mspec/lib/mspec/commands/mspec-run.rb:94:in `run'
/home/akr/fix2int/mspec/lib/mspec/utils/script.rb:218:in `main'
/home/akr/fix2int/mspec/bin/mspec-run:8:in `<main>'

Finished in 0.003072 seconds

1 file, 15 examples, 17 expectations, 1 failure, 0 errors
% ruby mspec/bin/mspec -t r40029/bin/ruby rubyspec/optional/capi/fixnum_spec.rb
ruby 2.1.0dev (2013-04-01 trunk 40029) [x86_64-linux]
.F.............

1)
CApiFixnumSpecs rb_fix2uint raises a RangeError when given a negative value FAILED
Expected RangeError but no exception was raised (-1 was returned)
/home/akr/fix2int/mspec/lib/mspec/expectations/expectations.rb:15:in `fail_with'
/home/akr/fix2int/mspec/lib/mspec/expectations/should.rb:8:in `should'
/home/akr/fix2int/rubyspec/optional/capi/fixnum_spec.rb:17:in `block (4 levels) in <top (required)>'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `instance_eval'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `block in protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `all?'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:179:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:208:in `block (2 levels) in process'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:239:in `block in repeat'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:238:in `times'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:238:in `repeat'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:200:in `block in process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:199:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:199:in `process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `block in process'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/context.rb:230:in `process'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:38:in `describe'
/home/akr/fix2int/mspec/lib/mspec/runner/object.rb:11:in `describe'
/home/akr/fix2int/rubyspec/optional/capi/fixnum_spec.rb:5:in `<top (required)>'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `load'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `block (2 levels) in files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `instance_eval'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:69:in `protect'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:57:in `block in files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:51:in `each'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:51:in `files'
/home/akr/fix2int/mspec/lib/mspec/runner/mspec.rb:43:in `process'
/home/akr/fix2int/mspec/lib/mspec/commands/mspec-run.rb:94:in `run'
/home/akr/fix2int/mspec/lib/mspec/utils/script.rb:218:in `main'
/home/akr/fix2int/mspec/bin/mspec-run:8:in `<main>'

Finished in 0.003090 seconds

1 file, 15 examples, 17 expectations, 1 failure, 0 errors

----------------------------------------
Bug #9089: rb_fix2uint no longer raises a RangeError when given negative values
https://bugs.ruby-lang.org/issues/9089#change-42789

Author: NoKarma (Arthur Schreiber)
Status: Feedback
Priority: Normal
Assignee: 
Category: core
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-11-07 trunk 43560)
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


Up until the change that was made in ((<URL:https://github.com/ruby/ruby/commit/92f59c6d7937b14bb5eefb052099ef0a3ef3bcd0>)), (({rb_fix2uint})) would raise a (({RangeError})) if it was given a negative value like (({-1})) (e.g. when using the (({FIX2UINT})) macro).

Due to the changes made in that commit, this error is no longer raised and (({rb_fix2uint})) will return an incorrect value instead.

There is a C-API spec in rubyspec that shows that this behavior has changed between 2.0.0-p247 and 2.1.0-preview1, and I checked and made sure this is still not working correctly in the latest 2.1.0-dev version. The failing spec can be found at ((<URL:https://github.com/rubyspec/rubyspec/blob/master/optional/capi/fixnum_spec.rb#L16-L18>)), it is part of the "optional" c-api specs.

Is there any reason why there is the (({if (num < (unsigned long)INT_MIN)})) is made inside the (({check_uint})) function? Doesn't the (({sign})) parameter automatically indicate that we can't convert to an unsigned integer?


-- 
http://bugs.ruby-lang.org/

Thread

Prev Next

In This Thread

Prev Next

[#58120] [ruby-trunk - Feature #9070][Open] Introduce `---` as synonym of `end` keyword — "alexeymuranov (Alexey Muranov)" <redmine@...>

[#58123] [ruby-trunk - Feature #9071][Open] Enumerable#slice_after — "sawa (Tsuyoshi Sawada)" <sawadatsuyoshi@...>

[#58126] Ruby ruby-2.0.0-p247 on AIX 6.1 TL07 SP03 — Perry Smith <pedzsan@...>

[#58131] [ruby-trunk - Bug #9073][Open] Array#join encoding problem — 046569 (瀚林 李) <046569@...>

[#58137] [ruby-trunk - Bug #9074][Open] Doc promotes inadequate way to sanitize a filename — "cphoenix (Chris Phoenix)" <cphoenix@...>

[#58140] [ruby-trunk - Bug #9075][Open] ruby fails to compile enc/trans/big5.c — "_rpq (r pq)" <rpq@...>

[#58149] [ruby-trunk - Feature #9076][Open] New one-argument block syntax: &. — "asterite (Ary Borenszweig)" <ary@...>

[#58153] [ruby-trunk - Bug #9077][Open] RDoc typographical error — "sawa (Tsuyoshi Sawada)" <sawadatsuyoshi@...>

[#58158] [ruby-trunk - misc #9078][Open] Q: Why the Roadmap states that v2.1 is due in about 14 months (12/25/2014) whereas in the bullet notes it is scheduled for release on 2013-12-25 — "dsbonev (Dimitar Bonev)" <dsbonev@...>

[#58159] [ruby-trunk - Bug #9079][Open] Interpolated Symbol creates unnecessary intermediate String on the heap — "wycats (Yehuda Katz)" <wycats@...>

[#58160] [ruby-trunk - Bug #9080][Open] ENV[key] produces three objects — "wycats (Yehuda Katz)" <wycats@...>

[#58162] [ruby-trunk - Bug #9081][Open] Unexpected result for and opreator — "aminhotob (Mo Amin)" <m.h.ameen13@...>

[#58175] [ruby-trunk - Feature #5446] at_fork callback API — "sam.saffron (Sam Saffron)" <sam.saffron@...>

[#58176] [ruby-trunk - Bug #9082][Open] popen3 hangs when stderr gets lots of output — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

[#58182] [ruby-trunk - Bug #9083][Open] BasicObject#method_missing does not always raise NoMethodError for missing methods — "rits (First Last)" <redmine@...>

[#58191] [Backport 200 - Backport #9084][Open] Please backport fix for Debian GNU/kFreeBSD build — "terceiro (Antonio Terceiro)" <terceiro@...>

[#58193] [ruby-trunk - Bug #9085][Open] contents of io-console.gemspec not reproducible — "terceiro (Antonio Terceiro)" <terceiro@...>

[#58195] [ruby-trunk - Feature #5446] at_fork callback API — "jasonrclark (Jason Clark)" <jclark@...>

[#58196] [ruby-trunk - Bug #9086][Open] lib/rubygems/LICENSE.txt does not match LICENSE.txt from http://github.com/rubygems/rubygems — "terceiro (Antonio Terceiro)" <terceiro@...>

[#58199] [ruby-trunk - Bug #9087][Open] swallowing "s" letters when "i" flag is on — "mg (Dawid Grzesiak)" <dmg2010@...>

[#58207] [ruby-trunk - Bug #9089][Open] rb_fix2uint no longer raises a RangeError when given negative values — "NoKarma (Arthur Schreiber)" <schreiber.arthur@...>

[#58211] [ruby-trunk - Bug #9091][Open] [PATCH] accept_nonblock supports "exception: false" — "normalperson (Eric Wong)" <normalperson@...>

[#58212] [ruby-trunk - Bug #9092][Open] Update Unicode data to Unicode Version 6.3 — duerst (Martin Dürst) <duerst@...>

[#58217] [ruby-trunk - Bug #4044] Regex matching errors when using \W character class and /i option — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

[#58220] [ruby-trunk - Bug #9093][Assigned] Resolv: Multiple strings should be concatenated in a DNS record's data — "zzak (Zachary Scott)" <e@...>

[#58223] [ruby-trunk - Bug #9094][Open] Curses.getch() function responds twice for unicode keys — "walles (Johan Walles)" <johan.walles@...>

[#58226] [ruby-trunk - Feature #9095][Open] Allow `Symbol#to_proc` to take arguments — "alexeymuranov (Alexey Muranov)" <redmine@...>

[#58229] [ruby-trunk - Bug #9096][Open] Regexp.quote(UTF-8) returns US-ASCII — "walles (Johan Walles)" <johan.walles@...>

[#58232] [ruby-trunk - misc #9097][Open] no email notifications for bugs.ruby-lang.org — "mpapis (Michal Papis)" <mpapis@...>

[#58243] [ruby-trunk - Feature #9098][Open] Indent heredoc against the left margin by default when "indented closing identifier" is turned on. — "sikachu (Prem Sichanugrist)" <s@...>

[#58259] [ruby-trunk - Feature #9099][Open] Train emoji lambda operator — "charliesome (Charlie Somerville)" <charliesome@...>

[#58263] [Ruby 1.8 - Bug #9100][Open] Just a typo in a #define that is not used anywhere — "BertramScharpf (Bertram Scharpf)" <software@...>

[#58264] [ruby-trunk - Bug #9101][Open] Reference to unset variable — "BertramScharpf (Bertram Scharpf)" <software@...>

[#58266] [ruby-trunk - Bug #9102][Open] ObjectSpace.dump_all creates a FD without close-on-exec flag — "akr (Akira Tanaka)" <akr@...>

[#58277] Openssl: included is a method for retrieving signed data — "Carlo E. Prelz" <fluido@...>

[#58288] [ruby-trunk - Bug #9103][Open] Segmentation fault. ROR/rubypython/Sidekiq stack. — "voiper.it (Anton Maljanin)" <voiper.it@...>

[#58290] [ruby-trunk - Bug #4044] Regex matching errors when using \W character class and /i option — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

[#58292] Segmentation fault after raise — Bertram Scharpf <lists@...>

[#58300] [Backport 200 - Backport #9104][Assigned] Import RubyGems 2.0.14 — "drbrain (Eric Hodel)" <drbrain@...7.net>

[#58302] [ruby-trunk - Bug #4044][Feedback] Regex matching errors when using \W character class and /i option — "zzak (Zachary Scott)" <e@...>

[#58306] [ruby-trunk - Bug #9106][Open] 'gem install' doesn't copy .so files of ext libs — "tagomoris (Satoshi TAGOMORI)" <tagomoris@...>

[#58312] [ruby-trunk - Feature #9107][Open] Introduce YES and NO as aliases of true and false — "gsamokovarov (Genadi Samokovarov)" <gsamokovarov@...>

[#58324] [ruby-trunk - Feature #9108][Open] Hash sub-selections — "wardrop (Tom Wardrop)" <tom@...>

[#58329] [ruby-trunk - Bug #9110][Open] double free or corruption error at_exit with callcc — "Glass_saga (Masaki Matsushita)" <glass.saga@...>

[#58337] [ruby-trunk - Feature #9111][Open] Encoding-free String comparison — "sawa (Tsuyoshi Sawada)" <sawadatsuyoshi@...>

[#58342] [ruby-trunk - Feature #9112][Open] Make module lookup more dynamic (Including modules into a module after it has already been included) — "PragTob (Tobias Pfeiffer)" <pragtob@...>

[#58350] [ruby-trunk - Feature #9113][Open] Ship Ruby for Linux with jemalloc out-of-the-box — "sam.saffron (Sam Saffron)" <sam.saffron@...>

[#58368] [ruby-trunk - Bug #9114][Open] InstructionSequence.compile w/tailcall_optimization: true, trace_instruction: false not working as expected — "garysweaver (Gary Weaver)" <garysweaver@...>

[#58374] [ruby-trunk - Bug #9115][Open] Logger traps all exceptions; breaks Timeout — "cphoenix (Chris Phoenix)" <cphoenix@...>

[#58375] [ruby-trunk - Feature #9116][Open] String#rsplit missing — "artagnon (Ramkumar Ramachandra)" <artagnon@...>

[#58377] [ruby-trunk - Bug #9117][Open] 43656 breakes openssl in stalic-ext ruby — "mpapis (Michal Papis)" <mpapis@...>

[#58378] [ruby-trunk - Feature #9118][Open] In Enumerable#to_a, use size to set array capa when possible — "HonoreDB (Aaron Weiner)" <aweiner@...>

[#58391] [ruby-trunk - Bug #9119][Assigned] TestTime#test_marshal_broken_offset broken under MinGW — "luislavena (Luis Lavena)" <luislavena@...>

[#58395] [ruby-trunk - Feature #9120][Open] [PATCH] Tests for a_call + a_return — "brandur (Brandur Leach)" <brandur@...>

[#58396] [ruby-trunk - Bug #9121][Open] [PATCH] Remove rbtree implementation of SortedSet due to performance regression — "xshay (Xavier Shay)" <contact@...>

[#58398] [ruby-trunk - Bug #9122][Open] requiring readline in a spawned ruby process with new process group can hang it — "gnufied (hemant kumar)" <gethemant@...>

[#58404] [ruby-trunk - Feature #9123][Open] Make Numeric#nonzero? behavior consistent with Numeric#zero? — "sferik (Erik Michaels-Ober)" <sferik@...>

[#58411] [ruby-trunk - Bug #9124][Open] TestSocket errors in test-all on Arch 64-bit — "jonforums (Jon Forums)" <redmine@...>

[#58418] [ruby-trunk - Bug #9125][Open] Net::SMTP - invalid method raised when attempting to connect using STARTTLS — "pveselov (Pawel Veselov)" <pawel.veselov@...>

[#58419] [Backport 200 - Backport #9126][Open] game online free — "Parafriv (Para friv)" <frivpara@...>

[#58429] [Ruby 1.8 - Feature #4239][Closed] Let's begin a talk for "1.8.8" -- How's needed for surviving 1.8? — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#58430] [Backport 200 - Backport #9127][Open] URI::Generic#normalize documentation is vague. — "robertgleeson (Robert Gleeson)" <redmine@...>

[#58431] [Ruby 1.8 - Feature #4148][Closed] Time#strftime with %T broken on Windows — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#58432] [Ruby 1.8 - Backport #2180][Closed] request: add *Method#source_location to 1.8.x — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#58433] [Ruby 1.8 - Bug #851][Closed] Add rb_warning() around where behavior will change in 1.9.1 — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#58434] [Ruby 1.8 - Bug #1454][Closed] compatability of rational and bigdecimal (1.8 and 1.9) — "shyouhei (Shyouhei Urabe)" <shyouhei@...>

[#58435] [ruby-trunk - misc #9128][Open] Clarify documentation on difference between Object#clone and Object#dup — "stevegoobermanhill (stephen gooberman-hill)" <stevegoobermanhill@...>

[#58438] [ruby-trunk - Bug #9129][Open] Regression in support for IPv6 literals in URIs with Net::HTTP — "kallistec (Daniel DeLeo)" <dan@...>

[#58442] [ruby-trunk - Bug #9130][Open] logger continues to write in old log file after rotation — "no6v (Nobuhiro IMAI)" <nov@...>

[#58444] [Backport 200 - Backport #9131][Open] r43732 commit miss of version.h update — "jonforums (Jon Forums)" <redmine@...>

[#58449] [Backport 200 - Backport #9132][Open] Mutex error while using EM.defer with Ruby 2.0.0 — "shurab (Alexander Babichev)" <rxjc34@...>

[#58452] [ruby-trunk - Bug #9133][Open] logger rotates log files more than expected — "no6v (Nobuhiro IMAI)" <nov@...>

[#58455] [ruby-trunk - Bug #9134][Open] RUBY_HEAP_MIN_SLOTS does not work correctly in Ruby 2.0 — "sam.saffron (Sam Saffron)" <sam.saffron@...>

[#58461] [ruby-trunk - Bug #9135][Open] ruby 2.0.0p247 [BUG] Bus Error — runfor (Илья Конюхов) <runfor@...>

[#58463] [ruby-trunk - misc #9136][Open] Deprecated Enumerator.new(object, method) bad for BasicObject — "atlas (Atlas Prime)" <a7145@...>

[#58473] Object identity for string hash keys — Andrew Vit <andrew@...>

[#58474] [ruby-trunk - Bug #9137][Open] RUBY_FREE_MIN is not enforced correctly — "sam.saffron (Sam Saffron)" <sam.saffron@...>

[#58488] [ruby-trunk - Bug #9138][Assigned] make initialize_copy private — "zzak (Zachary Scott)" <e@...>

[#58490] Re: [ruby-cvs:50910] drbrain:r43767 (trunk): * lib/rubygems: Update to RubyGems master 50a8210. Important changes — Tanaka Akira <akr@...>

[#58493] [ruby-trunk - Bug #9139][Open] each_with_index — "dostapn (Dima Ostapenko)" <dostapn@...>

[#58131] [ruby-trunk - Bug #9073][Open] Array#join encoding problem — 046569 (瀚林李) <046569@...>