[#57574] [ruby-trunk - Feature #8976][Open] file-scope freeze_string directive — "akr (Akira Tanaka)" <akr@...>

70 messages 2013/10/02

[#57579] [ruby-trunk - Feature #8977][Open] String#frozen that takes advantage of the deduping — "sam.saffron (Sam Saffron)" <sam.saffron@...>

25 messages 2013/10/02

[#57679] [ruby-trunk - Feature #8987][Open] map/collect extension which handles arguments — "sowieso (So Wieso)" <sowieso@...>

16 messages 2013/10/05

[#57705] [ruby-trunk - Feature #8992][Open] Use String#freeze and compiler tricks to replace "str"f suffix — "headius (Charles Nutter)" <headius@...>

43 messages 2013/10/07

[#57727] [ruby-trunk - Feature #8998][Open] string keys for hash literals should use fstrings — "normalperson (Eric Wong)" <normalperson@...>

17 messages 2013/10/08

[#57771] [ruby-trunk - Bug #9008][Open] TestProcess#test_clock_getres_constants and TestProcess#test_clock_gettime_constants fails on ARM — "vo.x (Vit Ondruch)" <v.ondruch@...>

15 messages 2013/10/09

[#57888] [ruby-trunk - Feature #9025][Open] Clarify the error message when calling a method with the wrong number of arguments — Nerian (Gonzalo Rodríguez) <siotopo@...>

11 messages 2013/10/15

[#57993] [ruby-trunk - Feature #9047][Open] Alternate hash key syntax for symbols — "jamonholmgren (Jamon Holmgren)" <jamon@...>

13 messages 2013/10/23

[#58007] [ruby-trunk - Feature #9049][Open] Shorthands (a:b, *) for inclusive indexing — "mohawkjohn (John Woods)" <john.o.woods@...>

25 messages 2013/10/24

[#58033] [ruby-trunk - Bug #9053][Open] SSL Issue with Ruby 2.0.0 — "tisba (Sebastian Cohnen)" <ruby-lang@...>

16 messages 2013/10/25

[#58080] [ruby-trunk - Feature #9064][Open] Add support for packages, like in Java — "rosenfeld (Rodrigo Rosenfeld Rosas)" <rr.rosas@...>

23 messages 2013/10/30

[ruby-core:57813] ruby-2.0.0-p247siphash.c:443: bug report

From: David Binderman <dcb314@...>
Date: 2013-10-10 14:43:30 UTC
List: ruby-core #57813
Hello there,

I just ran the static analysis tool cppcheck over the source code
of ruby-2.0.0-p247

It said

[siphash.c:443] -> [siphash.c:445]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:445] -> [siphash.c:447]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:447] -> [siphash.c:460]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:460] -> [siphash.c:462]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:462] -> [siphash.c:464]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

switch (len % sizeof(uint64_t)) {
case 7:
OR_BYTE(6);
case 6:
OR_BYTE(5);
case 5:
OR_BYTE(4);

Suggest add some break statements.

Regards

David Binderman 		 	   		  

In This Thread

Prev Next