From: David Binderman <dcb314@...>
Date: 2013-10-10T14:43:30+00:00
Subject: [ruby-core:57813] ruby-2.0.0-p247siphash.c:443: bug report

Hello there,

I just ran the static analysis tool cppcheck over the source code
of ruby-2.0.0-p247

It said

[siphash.c:443] -> [siphash.c:445]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:445] -> [siphash.c:447]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:447] -> [siphash.c:460]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:460] -> [siphash.c:462]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?
[siphash.c:462] -> [siphash.c:464]: (warning) Variable 'last' is reassigned a value before the old one has been used. 'break;' missing?

Source code is

��� switch (len % sizeof(uint64_t)) {
��� case 7:
������� OR_BYTE(6);
��� case 6:
������� OR_BYTE(5);
��� case 5:
������� OR_BYTE(4);

Suggest add some break statements.

Regards

David Binderman