From: "Юрий Соколов" <funny.falcon@...>
Date: 2013-03-30T05:48:11+09:00
Subject: [ruby-core:53831] Re: [ruby-trunk - Bug #8165] Problems with require

--047d7bb03a5072df9504d91663fd
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

My patch doesn't store any string value, only hashes of them. It relies on
loaded_feature_path for string comparison.

Nor it uses ruby arrays for index storage - it organize them in linked
lists which are stored in a single C array.
29.03.2013 20:14 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=CC=D8 "h.shirosaki (Hiroshi=
 Shirosaki)" <
h.shirosaki@gmail.com> =CE=C1=D0=C9=D3=C1=CC:

>
> Issue #8165 has been updated by h.shirosaki (Hiroshi Shirosaki).
>
>
> funny_falcon (Yura Sokolov) wrote:
> > May be it will be simpler to accept
> https://bugs.ruby-lang.org/issues/8158 ?
> >  It has less memory requirement, avoids string comparisons, etc
> >
>
> Indeed your patch would not have this bug since using C string instead of
> string object.
> I think smaller patch or splitting patch might be better to be reviewed.
>
>
> ----------------------------------------
> Bug #8165: Problems with require
> https://bugs.ruby-lang.org/issues/8165#change-38032
>
> Author: Krugloff (Alexandr Kruglov)
> Status: Assigned
> Priority: Normal
> Assignee: tarui (Masaya Tarui)
> Category:
> Target version: current: 2.1.0
> ruby -v: ruby 2.0.0-p0
>
>
> Require doesn't work correctly if path contains cyrillic.
>
> require '/home/mak/test.rb' #-> true
> require '/home/mak/test.rb' #-> false
>
> require '/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb' #-> true
> require '/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb' #-> true
>
>
> --
> http://bugs.ruby-lang.org/
>
>

--047d7bb03a5072df9504d91663fd
Content-Type: text/html; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

<p dir=3D"ltr">My patch doesn&#39;t store any string value, only hashes of =
them. It relies on loaded_feature_path for string comparison.</p>
<p dir=3D"ltr">Nor it uses ruby arrays for index storage - it organize them=
 in linked lists which are stored in a single C array.</p>
<div class=3D"gmail_quote">29.03.2013 20:14 =D0=CF=CC=D8=DA=CF=D7=C1=D4=C5=
=CC=D8 &quot;h.shirosaki (Hiroshi Shirosaki)&quot; &lt;<a href=3D"mailto:h.=
shirosaki@gmail.com">h.shirosaki@gmail.com</a>&gt; =CE=C1=D0=C9=D3=C1=CC:<b=
r type=3D"attribution"><blockquote class=3D"gmail_quote" style=3D"margin:0 =
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Issue #8165 has been updated by h.shirosaki (Hiroshi Shirosaki).<br>
<br>
<br>
funny_falcon (Yura Sokolov) wrote:<br>
&gt; May be it will be simpler to accept <a href=3D"https://bugs.ruby-lang.=
org/issues/8158" target=3D"_blank">https://bugs.ruby-lang.org/issues/8158</=
a> ?<br>
&gt; =9AIt has less memory requirement, avoids string comparisons, etc<br>
&gt;<br>
<br>
Indeed your patch would not have this bug since using C string instead of s=
tring object.<br>
I think smaller patch or splitting patch might be better to be reviewed.<br=
>
<br>
<br>
----------------------------------------<br>
Bug #8165: Problems with require<br>
<a href=3D"https://bugs.ruby-lang.org/issues/8165#change-38032" target=3D"_=
blank">https://bugs.ruby-lang.org/issues/8165#change-38032</a><br>
<br>
Author: Krugloff (Alexandr Kruglov)<br>
Status: Assigned<br>
Priority: Normal<br>
Assignee: tarui (Masaya Tarui)<br>
Category:<br>
Target version: current: 2.1.0<br>
ruby -v: ruby 2.0.0-p0<br>
<br>
<br>
Require doesn&#39;t work correctly if path contains cyrillic.<br>
<br>
require &#39;/home/mak/test.rb&#39; #-&gt; true<br>
require &#39;/home/mak/test.rb&#39; #-&gt; false<br>
<br>
require &#39;/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb&#39; #-&gt; true<br>
require &#39;/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb&#39; #-&gt; true<br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
<br>
</blockquote></div>

--047d7bb03a5072df9504d91663fd--