From: "Юрий Соколов" <funny.falcon@...>
Date: 2013-03-29T20:39:40+09:00
Subject: [ruby-core:53821] Re: [ruby-trunk - Bug #8165] Problems with require

--047d7bfcf274da1a4804d90eb920
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

May be it will be simpler to accept https://bugs.ruby-lang.org/issues/8158 =
?
It has less memory requirement, avoids string comparisons, etc

(yes, i'm annoying a bit, sorry)


2013/3/29 h.shirosaki (Hiroshi Shirosaki) <h.shirosaki@gmail.com>

>
> Issue #8165 has been updated by h.shirosaki (Hiroshi Shirosaki).
>
> File 0001-load.c-fix-require-with-non-ascii-path.patch added
>
> One more issue seems string encoding.
> When looking up a feature name in rb_feature_p(), encoding information
> lacks.
> So `short_feature' should not have encoding.
> If encoding of the two non-ascii strings is different, hash value would b=
e
> different.
>
> load.c: rb_feature_p()
>
>     feature_val =3D rb_str_new(feature, len); // not have encoding
>
>     this_feature_index =3D rb_hash_lookup(features_index, feature_val);
>
>
> I've attached a patch. Tested on both trunk and 2.0.0 branch.
>
> ruby 2.1.0dev (2013-03-29 trunk 39991) [x86_64-linux]
> ruby 2.0.0p100 (2013-03-27 revision 39954) [x86_64-linux]
> ----------------------------------------
> Bug #8165: Problems with require
> https://bugs.ruby-lang.org/issues/8165#change-38028
>
> Author: Krugloff (Alexandr Kruglov)
> Status: Assigned
> Priority: Normal
> Assignee: tarui (Masaya Tarui)
> Category:
> Target version: current: 2.1.0
> ruby -v: ruby 2.0.0-p0
>
>
> Require doesn't work correctly if path contains cyrillic.
>
> require '/home/mak/test.rb' #-> true
> require '/home/mak/test.rb' #-> false
>
> require '/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb' #-> true
> require '/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb' #-> true
>
>
> --
> http://bugs.ruby-lang.org/
>
>

--047d7bfcf274da1a4804d90eb920
Content-Type: text/html; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><span style=3D"font-family:arial,sans-serif;font-size:12.8=
00000190734863px">May be it will be simpler to accept=9A</span><a href=3D"h=
ttps://bugs.ruby-lang.org/issues/8158" target=3D"_blank" style=3D"font-fami=
ly:arial,sans-serif;font-size:12.800000190734863px">https://bugs.ruby-lang.=
org/issues/8158</a>=9A? It has less memory requirement, avoids string compa=
risons, etc<br>
<div><br></div><div style>(yes, i&#39;m annoying a bit, sorry)</div></div><=
div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">2013/3/29 h.sh=
irosaki (Hiroshi Shirosaki) <span dir=3D"ltr">&lt;<a href=3D"mailto:h.shiro=
saki@gmail.com" target=3D"_blank">h.shirosaki@gmail.com</a>&gt;</span><br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"im"><br>
Issue #8165 has been updated by h.shirosaki (Hiroshi Shirosaki).<br>
<br>
</div>File 0001-load.c-fix-require-with-non-ascii-path.patch added<br>
<br>
One more issue seems string encoding.<br>
When looking up a feature name in rb_feature_p(), encoding information lack=
s.<br>
So `short_feature&#39; should not have encoding.<br>
If encoding of the two non-ascii strings is different, hash value would be =
different.<br>
<br>
load.c: rb_feature_p()<br>
<br>
=9A =9A feature_val =3D rb_str_new(feature, len); // not have encoding<br>
<br>
=9A =9A this_feature_index =3D rb_hash_lookup(features_index, feature_val);=
<br>
<br>
<br>
I&#39;ve attached a patch. Tested on both trunk and 2.0.0 branch.<br>
<br>
ruby 2.1.0dev (2013-03-29 trunk 39991) [x86_64-linux]<br>
ruby 2.0.0p100 (2013-03-27 revision 39954) [x86_64-linux]<br>
<div class=3D"im">----------------------------------------<br>
Bug #8165: Problems with require<br>
</div><a href=3D"https://bugs.ruby-lang.org/issues/8165#change-38028" targe=
t=3D"_blank">https://bugs.ruby-lang.org/issues/8165#change-38028</a><br>
<br>
Author: Krugloff (Alexandr Kruglov)<br>
<div class=3D"im HOEnZb">Status: Assigned<br>
Priority: Normal<br>
Assignee: tarui (Masaya Tarui)<br>
Category:<br>
Target version: current: 2.1.0<br>
</div><div class=3D"HOEnZb"><div class=3D"h5">ruby -v: ruby 2.0.0-p0<br>
<br>
<br>
Require doesn&#39;t work correctly if path contains cyrillic.<br>
<br>
require &#39;/home/mak/test.rb&#39; #-&gt; true<br>
require &#39;/home/mak/test.rb&#39; #-&gt; false<br>
<br>
require &#39;/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb&#39; #-&gt; true<br>
require &#39;/home/mak/=F0=D2=CF=C5=CB=D4=D9/test.rb&#39; #-&gt; true<br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
<br>
</div></div></blockquote></div><br></div>

--047d7bfcf274da1a4804d90eb920--