From: Akinori MUSHA <knu@...>
Date: 2012-12-27T02:26:43+09:00
Subject: [ruby-core:51150] Re: ruby-mode.el: indentation problem

--pgp-sign-Multipart_Thu_Dec_27_02:26:42_2012-1
Content-Type: text/plain; charset=US-ASCII

At Wed, 26 Dec 2012 20:54:04 +0400,
Dmitry Gutov wrote:
> Hi Akinori,
>
> On 26.12.2012 16:59, Akinori MUSHA wrote:
> > Thanks for maintaining ruby-mode.el.
> >
> > I found the other day that ruby-mode bundled with Emacs at least
> > 24.2.91 and later fails to indent the following piece of code
> > correctly:
> >
> >      var =
> >        begin
> >          val
> >        end
> >        statement  # should be dedented
> >        #...
> >
> > Where Emacs 24.2.1 and prior never had this problem.
> >
> >      var =
> >        begin
> >          val
> >        end
> >      statement
> >      #...
> >
> > There have been a bunch of changes within this period, so I thought
> > I'd better ask you directly.
>
> Thanks for the report, although filing a bug might have been a tad
> better, because I would've referred to it in the commit message.

OK.  Thanks for the quick fix!

> > Do you have any clue to this?
>
> Not off the top of my head, but git bisect showed the problem quickly.
> I've committed the fix to the branch emacs-24, revision 111078. It
> will get merged into trunk in the next routine merge.

I wasn't quite aware of the automated test suite that can be used for
bisecting.  Next time I find something suspicious I'll make full use
of it for sure.

--
Akinori MUSHA / http://akinori.org/

--pgp-sign-Multipart_Thu_Dec_27_02:26:42_2012-1
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)

iEYEABECAAYFAlDbM1IACgkQkgvvx5/Z4e7zmQCfVpYJGC0kaGpKdccKbQ8Lo65/
QvcAn09p9zmRLECa6Hk2ZRVz9rkGJlum
=01y4
-----END PGP SIGNATURE-----

--pgp-sign-Multipart_Thu_Dec_27_02:26:42_2012-1--