From: Hiroshi Shirosaki Date: 2012-09-29T20:31:26+09:00 Subject: [ruby-core:47727] Re: [ruby-trunk - Bug #7076][Open] TestUnicodeEscape#test_basic failure on Windows On Fri, Sep 28, 2012 at 9:49 AM, U.Nakamura wrote: > Hello, > > In message "[ruby-core:47709] [ruby-trunk - Bug #7076][Open] TestUnicodeEscape#test_basic failure on Windows" > on Sep.27,2012 21:44:25, wrote: >> This patch works fine with chcp 437, 1252 and 65001. Jon also confirmed this. > > So, commit it, please. > > > Generally, you can commit a patch by judgment of you, as long as > it does not change the specification. > If it is change of tests like this time, please do not hesitate to do. > Hello, Thank you for comments. The patch had a problem, but I think it was fixed. And I have other patches for test issues which I see on my local. So committed those. With those patches test-all results seems fine even on Windows XP with gcc version 4.7.2 rubenvb build. -- Hiroshi Shirosaki